This repository has been archived by the owner on Aug 29, 2022. It is now read-only.
Improves progress percent calculation #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves a case where mapping a task over URLSessionTask's progress produces progress that doesn't smoothly change as the underlying work progresses.
zwaldowski
force-pushed
the
zwaldowski/better-progress-percents
branch
3 times, most recently
from
bed7a77
to
fe0ec7c
Compare
Improves a where syntax-only map and andThen (f.ex., unwrapping a tuple) would have an outsized effect on the task progress.
zwaldowski
force-pushed
the
zwaldowski/better-progress-percents
branch
from
fe0ec7c
to
306782a
Compare
zwaldowski
changed the title
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Fixes two related problems:
Progressreturned byURLSessionUploadTaskhas a fraction like "(0 / 2)".Taskwould use only that fraction when aTaskusing thatProgresswas thenmaped orandThened, not reflecting the actual percentage ofURLSession's internals.map(f.ex., unwrapping some result) has an outsized effect on the end task, causing a progress bar to smoothly use 50% a network request loads, then leaping the remaining 50% as the trivial code gets executed.Testing
This affects the behavior of UI presentation, which wasn't adequately under test.
API Changes
None.