Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] When the printer is powered on, the BLTouch is deployed. #2454

Closed
magnificu opened this issue Mar 23, 2022 · 21 comments · Fixed by #2459
Closed

[BUG] When the printer is powered on, the BLTouch is deployed. #2454

magnificu opened this issue Mar 23, 2022 · 21 comments · Fixed by #2459
Labels
bug Something isn't working

Comments

@magnificu
Copy link

magnificu commented Mar 23, 2022

Description

When the printer is powered on, the BLTouch is deployed.
This can damage the probe if the user moves any axis.
All this happens after commit 2b97218.

This behavior should not be hard coded.

Expected behavior
When the printer is powered on, the probe should not be deployed (stay retracted).

@magnificu magnificu added the bug Something isn't working label Mar 23, 2022
@magnificu magnificu changed the title [BUG] When the printer is powered on the BLTouch is deployed. [BUG] When the printer is powered on, the BLTouch is deployed. Mar 23, 2022
@kisslorand
Copy link
Contributor

Did you check #2452?

@rondlh
Copy link

rondlh commented Mar 23, 2022

Please provide all information requested by the bug report template.
The TFT doesn't do anything with the BLTouch during startup. What firmware are you using, if it's Marlin, then check your STARTUP_COMMANDS

@kisslorand
Copy link
Contributor

kisslorand commented Mar 23, 2022

The TFT doesn't do anything with the BLTouch during startup.

Actually it does. It checks the HS mode of BLTouch. (M401 H)

magnificu's version of Marlin doesn't have this capability to report the BLTouch's HS mode, hence it ignores the "H" parameter and executes only "M401" (deploy BLTouch).

@magnificu
Copy link
Author

magnificu commented Mar 23, 2022

Using the same Marlin version.

BIGTREE_TFT50_V3.0.27.x.bin -> from 10.03.2022 does not deploys the probe.
BIGTREE_TFT50_V3.0.27.x.bin -> from 21.03.2022 deploys the probe.

The problem is that M401 H deploys the probe when the HS mode is disabled in Marlin !!!
(//#define BLTOUCH_HS_MODE true)

Not all the users have/use HS mode.
Again, such a behavior should not be hard coded in the source code.

It is dangerous and can damage precious hardware.

@kisslorand
Copy link
Contributor

kisslorand commented Mar 23, 2022

@magnificu

The problem is that M401 H deploys the probe when the HS mode is disabled in Marlin !!! (//#define BLTOUCH_HS_MODE true)

Your Marlin is not up to date, latest Marlin doesn't deploy the BLTouch with "M401 H" command.

Again, such a behavior should not be hard coded in the source code.

This behaviour is not coded in the TFT's FW. Your Marlin that is older than the TFT's FW is doing this.

@magnificu
Copy link
Author

Ok.
Thanks for the help.
When the TFT firmware requires a minimum Marlin version I guess a warning should be raised or at least a message on the printer display, but maybe as ask too much...

@kisslorand
Copy link
Contributor

kisslorand commented Mar 23, 2022

It was you who mentioned commit 2b97218 from PR #2393. I guess you missed what is written in that PR so I copy & paste it here for you:

Requirements:

  • BTT or MKS TFT
  • a BL Touch bed levelling sensor or alike
  • Marlin from 12.III.2022 or newer
  • "#define BLTOUCH_HS_MODE true" in Marlin's "Configuration_adv.h"

but maybe as ask too much...

Maybe asking users to search and read before complaining is asking too much...
Anyway, you're welcome.

@sarvenn
Copy link

sarvenn commented Mar 24, 2022

@kisslorand hi,
I could not find the option for HS mode on/off you implemented with #2393.
My marlin is up to date and HS mode is true. I expected to see this feature under BL touch menu under ABL where I can stow, deploy, test or reset my BL touch. But it wasn't there. Am I doing something wrong or missing something. I read the explanation but I must be missing something. Would you help?

@kisslorand
Copy link
Contributor

Send "M401 H" to Marlin and check if you got a response or not from Marlin.

@sarvenn
Copy link

sarvenn commented Mar 24, 2022

I will but isn't there a button to switch on/off in TFT mode? I understood like that from your PR.
Should I use the terminal to send Gcode for on and off command?

@kisslorand
Copy link
Contributor

kisslorand commented Mar 24, 2022

Yes, there's a button, but it is visible(active) only if HS mode is set to true in Marlin. All this only in Marlin from 12.III.2022.
That's why I told you to send "M401 H" to check if your Marlin has the capability to report BLTouch HS mode state.

@rondlh
Copy link

rondlh commented Mar 24, 2022

Sending a "M402" after the "M401 H" could be an easy workaround.
This seems to have been fixed in the latest Marlin 2.0.x bug fix. I personally never use the Marlin bug fixes, I only use the stable Marlin releases, the Marlin March 13th update does not support the M401 H option yet.

@magnificu
Copy link
Author

In general I find it very strange to implement features that are not supported by the stable releases.
I guess it is happening just because there is no sponsor/maintainer with a minimum strategy and vision.

@kisslorand
Copy link
Contributor

kisslorand commented Mar 24, 2022

Sending a "M402" after the "M401 H" could be an easy workaround.

Upgrading to latest Marlin would be better, no workaround needed.

This seems to have been fixed in the latest Marlin 2.0.x bug fix.

It is not fixed, it is implemented. (MarlinFirmware/Marlin#23724)

I personally never use the Marlin bug fixes, I only use the stable Marlin releases, the Marlin March 13th update does not support the M401 H option yet.

The choice is yours, either you hold on to the TFT FW upgrade and wait for the Marlin stable release or you upgrade Marlin too.

@kisslorand
Copy link
Contributor

kisslorand commented Mar 24, 2022

In general I find it very strange to implement features that are not supported by the stable releases. I guess it is happening just because there is no sponsor/maintainer with a minimum strategy and vision.

What feature in the stable release of the TFT FW is not supported by Marlin's stable release? I am not aware of any so can you please enlighten us and point out what would be that feature that bothers you?

Anyway, there are solutions but even if they are not suitable for some of you here are more:

  1. comment "storeCmd("M401 H\n"); // check the state of BLTouch HighSpeed mode" in "parseACK.c" (line 436)
  2. add another command right after the above mentioned one: "storeCmd("M402\n");"

@kisslorand
Copy link
Contributor

#2459

@magnificu
Copy link
Author

The options about how to fix the "new feature" are clear, but some questions remain.
Why the average users should look for fixes after the TFT firmware update?
Why such a feature with potential to damage hardware is introduced without any notification or Marlin version check warning?

@kisslorand
Copy link
Contributor

Average users should stay away from nightly builds if they do not want to take any chance.
I do not know what you want other than ranting and fighting.

@sarvenn
Copy link

sarvenn commented Mar 26, 2022

Yes, there's a button, but it is visible(active) only if HS mode is set to true in Marlin. All this only in Marlin from 12.III.2022. That's why I told you to send "M401 H" to check if your Marlin has the capability to report BLTouch HS mode state.

Button is missing.
20220326_204612
20220326_204456

@kisslorand
Copy link
Contributor

@sarvenn
Are you sure you're on the latest BTT FW? I cannot reproduce the issue.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants