Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny fixes, tiny program size reduction #2459

Merged
merged 5 commits into from
Mar 26, 2022

Conversation

kisslorand
Copy link
Contributor

Requirements

BTT or MKS TFT

Description

  • BLTouch HS mode button updates from Marlin's feedback, not from desired value
  • tiny program size reduction
  • stow BLTouch probe after initial BLTouch HS mode check (guard for older Marlin than 12.III.2022)
  • some tiny HU language grammar fix

Related Issues

Fixes #2458
Fixes #2454
Fixes #2452

@digant73
Copy link
Contributor

digant73 commented Mar 25, 2022

At boot, parseAck.c should invoke only commands to retrieve capabilities (commands M115, M503 etc...) that are supported by any mainboard fw. Availability of features (such as BLTouch presence) are detected with M115 and menus are provided according to the detected capabilities. M401, M402 should simply be moved in the BLTouch menu (or even better only when the HS button is used). In my printer, at any boot the Z axis is also raised by some centimeters (plus the deployed probe).

@kisslorand
Copy link
Contributor Author

At boot, parseAck.c should invoke only commands to retrieve capabilities (commands M115, M503 etc...) that are supported by any mainboard fw. Availability of features (such as BLTouch presence) are detected with M115 and menus are provided according to the detected capabilities. M401, M402 should simply be moved in the BLTouch menu (or even better only when the HS button is used). In my printer, at any boot the Z axis is also raised by some centimeters (plus the deployed probe).

Sure, I will do it like this as soon as I get a little bit better.

@bigtreetech bigtreetech merged commit baf2ae2 into bigtreetech:master Mar 26, 2022
@kisslorand
Copy link
Contributor Author

kisslorand commented Mar 26, 2022

@digant73
I tested your suggestion and it is not optimal. At first usage of BLTouch menu it takes a long time for the HSMode button to change/update.

Later edit: fixed, HS mode check now in BLTouch menu

kisslorand added a commit to kisslorand/BIGTREETECH-TFT that referenced this pull request Mar 26, 2022
bigtreetech pushed a commit that referenced this pull request Mar 26, 2022
mehmetsutas pushed a commit to mehmetsutas/BIGTREETECH-TouchScreenFirmware that referenced this pull request May 24, 2022
mehmetsutas pushed a commit to mehmetsutas/BIGTREETECH-TouchScreenFirmware that referenced this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants