Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize landing zone creation with restrict collections enabled #1969

Open
mikkonie opened this issue Jul 25, 2024 · 0 comments
Open

Optimize landing zone creation with restrict collections enabled #1969

mikkonie opened this issue Jul 25, 2024 · 0 comments
Labels
app: landingzones Issue in the landingzones app feature Requested feature or enhancement

Comments

@mikkonie
Copy link
Contributor

mikkonie commented Jul 25, 2024

It is no secret that creating landing zones with both collection creation and restriction can be very slow for large assays (500+ samples).

The reason is that we create collections and apply ACLs individually for each collection. This scales linearly, so it can take quite a bit of time for a lot of collections.

I would like to think there is a way to do this without individual ACLs for every collection, while preserving no write access to user in the parent collection (that's the "restrict" part). However, I don't know how to implement it off the top of my head. Maybe disabling inheritance from parent collection after the operation?

Also, I need to double-check the current code for setting the ACLs. It is possible I have accidentally introduced some bottlenecks in the most recent changes to this, which I believe happened when updating taskflows for iRODS 4.3 API compatibility.

I will need to experiment. Pull requests are of course welcome from iRODS experts. Current tests should ensure the desired end result..

Workaround: Disable restrict collections and be careful about where you upload :)

@mikkonie mikkonie added feature Requested feature or enhancement app: landingzones Issue in the landingzones app labels Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: landingzones Issue in the landingzones app feature Requested feature or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant