Skip to content

Commit

Permalink
Apply suggested changes from review
Browse files Browse the repository at this point in the history
  • Loading branch information
aneust committed Nov 21, 2024
1 parent e039806 commit f2364e7
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 8 deletions.
7 changes: 2 additions & 5 deletions resources/assets/js/label-trees/components/labelTrees.vue
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,8 @@ export default {
});
},
},
focusInput(){
if(this.focusInput){
focusInput() {
if (this.focusInput) {
this.$refs.typeaheadInput.$el.querySelector('input').focus();
}
}
Expand Down Expand Up @@ -234,9 +234,6 @@ export default {
}
bindFavouriteKey('0', 9);
}
Events.$on('callFunctionFocustypeahead', () => {
this.focusTypeahead();
});
},
};
</script>
1 change: 0 additions & 1 deletion resources/views/annotations/show.blade.php
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@
ref="sidebar"
:open-tab="openTab"
:toggle-on-keyboard="true"
:focus-input="focusInputFindlabel"
v-on:open="handleOpenedTab"
v-on:close="handleClosedTab"
v-cloak>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/annotations/show/tabs/labels.blade.php
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<sidebar-tab name="labels" icon="tags" title="Label trees">
<labels-tab v-on:select="handleSelectedLabel" :focus-input="focusInputFindlabel" v-cloak inline-template>
<labels-tab v-on:select="handleSelectedLabel" v-on:open="openSidebarLabels" v-cloak inline-template>
<div class="labels-tab">
<div class="labels-tab__trees">
<label-trees :trees="labelTrees" :show-favourites="true" :focus-input="focusInput" v-on:select="handleSelectedLabel" v-on:deselect="handleDeselectedLabel" v-on:clear="handleDeselectedLabel"></label-trees>
<label-trees :trees="labelTrees" :show-favourites="true" :focus-input="focusInputFindlabel" v-on:select="handleSelectedLabel" v-on:deselect="handleDeselectedLabel" v-on:clear="handleDeselectedLabel"></label-trees>
</div>
<div class="labels-tab__plugins">
@mixin('annotationsLabelsTab')
Expand Down

0 comments on commit f2364e7

Please sign in to comment.