Add Database Migration for sorting images: #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jLeonBi
commented
May 31, 2021
jLeonBi
commented
- Add hash to images table
- Add similarity index to images table
- Add hash to images table - Add similarity index to images table
- HashValueGenrertor.py generates Hashvalue for one Image - SimilarityIndexGenerator.py generates the index for each Image by the hash value
- Job and Test for Generating Hash Value per Image - Job and Test for generating Similarity Index for Images
- Change Migrations to nullable - Write first Test that checks if string is in (does not work because of no Storga?) - Write Job for generating Image hash
- Add input and output to script - add constructor to similarityIndexjob - add nullable Job to HashGeneratorTest
mzur
reviewed
Jun 15, 2021
- extend biigle config with python and temp dir - rewrite get HashValue for input and output json
jLeonBi
commented
Jun 15, 2021
jLeonBi
commented
Jun 15, 2021
- correct syntax for setting hash value - Use getThumbnail function for getting bytstring image
- add input and output json - add dummy pythton in associated test - test where the teste case fail
jLeonBi
commented
Jun 16, 2021
mzur
reviewed
Jun 16, 2021
-add more mock function
jLeonBi
commented
Jun 21, 2021
- job generates the hash for an image and saves it - but insecure about so many mock functions
- update HashValueGenerator for Base64 images and test the in and output - update SimilarityIndexGenerator for in and output and test it also
- change from list with dict as entries to one dict with id as key and SI as value
mzur
reviewed
Jun 21, 2021
-The similarity index will be computed and assigned -Test execute positiv
mzur
reviewed
Jun 23, 2021
-remove stub functions in both test cases -change input and output from generateHashValue -change hash migration from string to longText
-remove 3 foreach parts and replace with one collection statement
-start GenerateHashValueJob in ProcessNewImage after thumbnail is created -start GenerateSimilarityIndex in GHV Job after asking if every image has hash -add one testimage in GHV Test for checking if every image in volume has hash
mzur
reviewed
Jun 25, 2021
database/migrations/2021_05_31_125925_add_hash_to_images_table.php
Outdated
Show resolved
Hide resolved
- suggestions in SimilarityIndexJob
mzur
requested changes
Jun 30, 2021
mzur
reviewed
Jul 11, 2021
mzur
reviewed
Jul 11, 2021
- create Test class for controller - create plane sorter Function
mzur
reviewed
Jul 14, 2021
mzur
reviewed
Jul 14, 2021
app/Http/Controllers/Api/Volumes/SimilarityIndicesController.php
Outdated
Show resolved
Hide resolved
- add old npmrc - add 404 if volume media type - import api
mzur
reviewed
Jul 15, 2021
-add Test for Missing one Sim index - add Test for missing all Sim indices -Test are not working because of not handling case
mzur
reviewed
Jul 19, 2021
app/Http/Controllers/Api/Volumes/SimilarityIndicesController.php
Outdated
Show resolved
Hide resolved
mzur
reviewed
Jul 21, 2021
app/Http/Controllers/Api/Volumes/SimilarityIndicesController.php
Outdated
Show resolved
Hide resolved
- add 404 error if similarity index is missing - fix similarity controller query - fix similarity sorter
|
Development of this feature can continue in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.