Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favourite label key icon #797 _ first attempt #840

Merged
merged 14 commits into from
Jun 18, 2024
Merged

Favourite label key icon #797 _ first attempt #840

merged 14 commits into from
Jun 18, 2024

Conversation

aneust
Copy link
Contributor

@aneust aneust commented May 29, 2024

Added keyboard icon and corresponding key to favorite label.

@aneust aneust closed this May 29, 2024
@aneust aneust reopened this May 29, 2024
@aneust aneust closed this May 29, 2024
@aneust
Copy link
Contributor Author

aneust commented May 29, 2024

possible to remove favorite by click on key, is not usefull

@aneust aneust reopened this May 29, 2024
@mzur
Copy link
Member

mzur commented May 29, 2024

Is this ready for review?

@aneust
Copy link
Contributor Author

aneust commented May 29, 2024

Yes

@mzur
Copy link
Member

mzur commented May 29, 2024

Then you can request my review in the top right ("Reviewers") by clicking on the gear icon and selecting me.

@mzur mzur linked an issue May 29, 2024 that may be closed by this pull request
@aneust aneust requested a review from mzur May 30, 2024 11:04
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! I left some minor comments.

@mzur
Copy link
Member

mzur commented Jun 13, 2024

Ready for review again? Please re-request my review whenever you are ready.

@aneust
Copy link
Contributor Author

aneust commented Jun 13, 2024

Not yet, wanted to check if the click on icon is like wanted.

@aneust aneust requested a review from mzur June 13, 2024 20:52
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect. Only two nitpicky comments left 😉

@aneust aneust requested a review from mzur June 17, 2024 08:08
@aneust aneust requested a review from mzur June 18, 2024 13:19
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mzur mzur merged commit 9d7d543 into master Jun 18, 2024
6 checks passed
@mzur mzur deleted the patch-1 branch June 18, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Favourite label key icon
2 participants