Upgrade OpenLayers to v9

[mzur]

This is an attempt to upgrade OpenLayers from v5 to the current v9. It may offer better performance and new features.

Plan:

• Migrate the canvas source from @biigle/ol to core
• Migrate the polygon brush from @biigle/ol to core
• Upgrade to OpenLayers v6. Check for relevant new features. Resolves Upgrade OpenLayers #250
  • Continue release notes at "Layers can only be added to a single map".
  • Walk through remaining v6 release notes.
• Upgrade to OpenLayers v7. Check for relevant new features.
  • Read release notes.
  • Walk through remaining v7 release notes.
• Upgrade to OpenLayers v8. Check for relevant new features.
  • Read release notes.
  • Walk through remaining v8 release notes.
• Upgrade to OpenLayers v9. Check for relevant new features.
  • Read release notes.
  • Walk through remaining v9 release notes.
• Enable the Rectangle and Ellipse geometry types again (either in core or in a @biigle/ol that is based on v9).
  • openlayers/openlayers@main...biigle:openlayers:v9-biigle
• Do extensive manual QA and comparison to v5 of all features (including shortcuts).
• Release @biigle/ol:v9.2.4.
• Upgrade use of @biigle/ol in:
  • biigle/magic-sam Upgrade to @biigle/ol:v9.2.4 magic-sam#26
  • biigle/reports Upgrade to @biigle/ol:v9.2.4 reports#124
  • biigle/geo Upgrade to @biigle/ol:v9.2.4 geo#55
  • biigle/laserpoints Upgrade to @biigle/ol:v9.2.4 laserpoints#80
  • biigle/maia Upgrade to @biigle/ol:v9.2.4 maia#174

Known issues:

• Capturing a screenshot does not produce a high-DPI image. Fix?
• Drawing and modifying with a polygon brush is slower. Maybe newer/slower turfjs? Fix?
• Selecting a complicated (magic wand) annotation is extremely slow. Fix?
  • Is the selectedAnnotations watcher necessary or does it double the work?
  • Maybe remove select interaction as described in SelectInteraction removal openlayers/openlayers#9961?
  • Use Layer#getFeatures(pixel) introduced in v6.1?
• Zooming and panning of images is sometimes (?) more janky. Fix?
  • The map object was accidentally made reactive through the minimap, which made everything slow.
• Static image display is flickering sometimes during zoom/pan. Fix?
  • It's only the image/canvas layer that's flickering. The annotation layer remains visible!
  • No idea. Only observed this sometimes in Firefox when the dev console is open. Never in Chrome.
• Video playback is faster with an updated implementation (that works with the minimap)!
• Seems to fix Zooming causes video to disappear in firefox #626.
• Zoom (to extent) buttons are smaller. Fix?
• Update magic wand snapshot only when tool is active and using throttle().
• Update video minimap more efficiently with source.change() instead of layer.change() so no render listener is required any more.
• Tiled image minimap sometimes flickers.
• Zoom to full image no longer has a padding. Fix?
• Selecting multiple overlapping annotations seems different. Fix?
• The video annotation tool shows a strange artifact at the bottom of the video.
  • Seems to be a Firefox thing. The video element is fine but once the video is drawn onto a canvas, the artifacts are there.
• Look for possible bottlenecks (e.g. event listeners) in image/video drawing.
  • Double render through drawn video frame and then refreshed annotations?
  • Is the selectedAnnotations watcher necessary or does it double the work?

[mzur]

@dlangenk @lehecht Could you please check out this branch and try to break the image/video annotation tools when you have time? After checking out the branch you have to run npm install and npm run dev once. This PR upgrades the most important third-party library in BIIGLE four major versions and I don't want to publish it before adequate eyeballing.

[dlangenk]

I found a bug, which wasn't there before (at least I can reproduce it at biigle.de) [Should we post them here?]

1. Activate the brush tool and draw an annotation.
2. Deactivate it and click on the newly created annotation
3. Activate the modify brush (T) and paint a new annotation to the top left of the current one, without intersection. (Edit: Anywhere to the left still leads to the bug)
4. The previous annotation is now gone and the new one is there.

[dlangenk]

I also get a warning in the console: No map visible because the map container's width or height are 0.

[dlangenk]

That is everything I found. So great work🎉

[mzur]

@dlangenk Thanks, this should be fixed now. It also fixed #873.

@lehecht Anything to add?