Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamed annotation response #967

Merged
merged 7 commits into from
Nov 27, 2024
Merged

Streamed annotation response #967

merged 7 commits into from
Nov 27, 2024

Conversation

lehecht
Copy link
Contributor

@lehecht lehecht commented Nov 7, 2024

Prevent exceeding memory limit for annotation get requests by using generator and stream.

Closes #946.

@lehecht lehecht requested a review from mzur November 7, 2024 07:50
app/Http/Controllers/Api/ImageAnnotationController.php Outdated Show resolved Hide resolved
app/Http/Controllers/Api/VideoAnnotationController.php Outdated Show resolved Hide resolved
tests/php/AnnotationSessionTest.php Show resolved Hide resolved
@lehecht lehecht requested a review from mzur November 13, 2024 06:46
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mzur mzur merged commit 47c52ad into master Nov 27, 2024
6 checks passed
@mzur mzur deleted the streamed-annotation-response branch November 27, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Streamed annotation responses
2 participants