-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add annotation outlines to Largo thumbnails #119
Conversation
I forgot to extend the tests. I'm working on it. |
Exclude whole frame video annotations, because they are not displayed as a shape.
Due to the svg annotation extension, the shape id for image video annotations is always needed.
I noticed that if you don't set at least the stroke color, lines and points are not drawn any more. So I need to add it before sending it to the frontend. Or do you have a better idea @mzur ? |
Do you have an example file? So if you don't set the stroke in the SVG, you can't set/add it via CSS later? |
Ah, yes. I no longer saw the annotation and thought that the data would also be gone somehow. But thanks for this reminder! |
How should I access the svgs? Currently they are named like the jpg just with the svg ending and are saved in the same directory. |
That's the way to go, IMO. You can load the SVGs in the same way than the thumbnails (via their public URL, since this storage disk is public). |
Ah okay. That was my first idea, but it seemed to easy and good to be accepted later. Thanks! 😄 |
Sometimes easy is also good 😄 |
df0a5f6
to
267fac6
Compare
Whole frame video annotation were not considered when requesting svgs. Bugfix handles these cases separately.
Separate SVG patch generation test from normal patch generation tests
I merged the master branch into this one, because I was not sure If I create merge conflicts when merging this branch into the master at the end. This branch was based on an older version of the master and I edited a file there, which was also edited on the newer master branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please read this before you act on my comments below 😉
I'm now almost finished with #120 and I would like to wrap up this PR, too. Almost everything that I would ask you to do here, I would have to change or do again during the merge between #120 and this PR. So I'd like to leave most things as they are now.
So here is what I'd like you to do to finish this PR:
- Fix checking for video SVG files in the GenerateMissing command (see comment below).
- Clarify why the point radius was changed (see comment below).
- Revert changes to the GenerateImage/VideoAnnotationPatch jobs and their tests (see comments below).
- Remove the GenerateImage/VideoAnnotationSVGPatch jobs and their tests again. This will be handled differently after the merge (there is a new ProcessAnnotatedImage job which will have flags to ignore patches/feature vectors/SVGs).
- Write a text in this PR that I can paste into the updated manual article.
- Compile and commit the files of
src/public/
.
@mzur |
Thanks a lot! This is a huge new feature 👍 I will take it from here. |
The outlines are shown in the relabel step now, too.
I decided to backtrack a bit (f7236f4) and display the SVGs as
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for all the work @lehecht!
Added by @mzur:
largo:generate-missing
console command to only generate missing SVGs. The command should also check the SVG existence and regenerate SVGs if they are missing by default.npm run prod
and commit the files ofsrc/public/
.