Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check images before creating maia annotations #171

Merged
merged 7 commits into from
Jun 19, 2024
Merged

Check images before creating maia annotations #171

merged 7 commits into from
Jun 19, 2024

Conversation

lehecht
Copy link
Contributor

@lehecht lehecht commented Jun 4, 2024 •
edited
Loading

  • Check that the image exists before processing annotations
  • Add test case for deleted image

Closes #121.

lehecht added 2 commits June 4, 2024 08:08
@lehecht
Fix error with removed images
2d882f6 
Delete annotations of already deleted images.
@lehecht
Add test
5669f68
@lehecht lehecht changed the title Fix missing img Check images before creating maia annotations Jun 4, 2024
@lehecht lehecht requested a review from mzur June 4, 2024 07:41
mzur
mzur requested changes Jun 6, 2024
View reviewed changes
src/Jobs/DetectionJob.php Outdated Show resolved Hide resolved
src/Jobs/DetectionJob.php Outdated Show resolved Hide resolved
@lehecht lehecht force-pushed the fix-missing-img branch from 321244e to 7a3b227 Compare June 7, 2024 07:04
@lehecht lehecht force-pushed the fix-missing-img branch from 7a3b227 to fb7ed27 Compare June 7, 2024 07:07
@lehecht lehecht requested a review from mzur June 7, 2024 07:12
mzur
mzur requested changes Jun 10, 2024
View reviewed changes
src/Jobs/DetectionJob.php Outdated Show resolved Hide resolved
tests/Jobs/ObjectDetectionTest.php Outdated Show resolved Hide resolved
@lehecht lehecht requested a review from mzur June 19, 2024 06:01
mzur
mzur approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@mzur mzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've just simplified the test a little more.

@mzur mzur merged commit 65eecd1 into master Jun 19, 2024
2 checks passed
@mzur mzur deleted the fix-missing-img branch June 19, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzur mzur mzur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter MAIA annotations before insert
2 participants
@lehecht @mzur