Merge deadpool-redis-cluster into deadpool-redis. #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bikeshedder I'm looking forward to your feedback on this pull-request. I'm not sure what your preference is with regards to documentation structure for this merge. Please let me know and / or feel free to push modifications to this PR. |
Merged
|
From #288:
Maybe a 0.1.1 with deprecation warnings would be best. That way the warnings are automatically printed by the Rust compiler and in the generated docs. |
bikeshedder
force-pushed
the
refactor_redis_cluster
branch
from
f3a38b7
to
3edc52b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bikeshedder this is my attempt to merge the
deadpool-redis-clusterinto thedeadpool-rediscrate + remove theredis_cluster_asyncdependency (#284). Feel free to push modifications to this pull-request :)