Timeouts: Make new() and wait_millis() const fns
#315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to declare `new()` as a `const fn` in the next commit.
This allows users to declare e.g. `const TIMEOUTS: Timeouts = Timeouts::wait_millis(500);` without the compiler screaming at them. This is made possible by the fact that `Duration::from_millis()` is also a `const fn` since Rust 1.32.
|
Makes sense! 👍 |
|
Could you please update the |
|
I just updated the CHANGELOG and published Thanks a lot! 🎉 |
|
sweet, thanks! (sorry, I just saw the comment above 🙈) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to declare e.g.
const TIMEOUTS: Timeouts = Timeouts::wait_millis(500);without the compiler screaming at them. This is made possible by the fact thatDuration::from_millis()is also aconst fnsince Rust 1.32.