[NOISSUE] fixed document reference url when converting from 2.1 to 3.0

bimspot · Jul 26, 2024 · 38be9e8 · 38be9e8
1 parent ceeba06
commit 38be9e8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/bcf-toolkit.sln.DotSettings.user b/bcf-toolkit.sln.DotSettings.user
@@ -35,6 +35,9 @@
 	<s:String x:Key="/Default/Environment/UnitTesting/UnitTestSessionStore/Sessions/=87607a24_002D24bc_002D46e1_002Da035_002D28c18ba9b643/@EntryIndexedValue">&lt;SessionState ContinuousTestingMode="0" IsActive="True" Name="All tests from Solution" xmlns="urn:schemas-jetbrains-com:jetbrains-ut-session"&gt;
   &lt;Solution /&gt;
 &lt;/SessionState&gt;</s:String>
+	<s:String x:Key="/Default/Environment/UnitTesting/UnitTestSessionStore/Sessions/=9b61e927_002Deb40_002D473c_002D8f88_002D4fda2fb23707/@EntryIndexedValue">&lt;SessionState ContinuousTestingMode="0" IsActive="True" Name="All tests from Solution #3" xmlns="urn:schemas-jetbrains-com:jetbrains-ut-session"&gt;
+  &lt;Solution /&gt;
+&lt;/SessionState&gt;</s:String>
 
 
 

diff --git a/src/bcf-toolkit/Converter/Bcf21/SchemaConverterToBcf30.cs b/src/bcf-toolkit/Converter/Bcf21/SchemaConverterToBcf30.cs
@@ -67,7 +67,6 @@ private static Model.Bcf30.Markup ConvertMarkup(Model.Bcf21.Markup from) {
         ? "OPEN"
         : from.Topic.TopicStatus)
       .AddDocumentReferences(from.Topic.DocumentReference
-        .Where(d => !d.IsExternal)
         .Select(ConvertDocumentReference).ToList());
 
     var bimSnippet = topic.BimSnippet;
@@ -123,7 +122,7 @@ private static Model.Bcf30.DocumentReference ConvertDocumentReference(
 
     builder
       .SetGuid(from.Guid ??= Guid.NewGuid().ToString())
-      .SetUrl(from.ReferencedDocument)
+      .SetUrl(from.IsExternal ? from.ReferencedDocument : null)
       //TODO: generate guid based on guid and description
       .SetDocumentGuid(Guid.NewGuid().ToString());