Skip to content
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.

Aizad/Fix Derived toggle click on reload #7293

Merged

Conversation

aizad-deriv
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Nov 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
binary-static ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 30, 2023 at 6:02AM (UTC)

@github-actions
Copy link

github-actions bot commented Nov 24, 2022

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/binary-static/pull/7293](https://github.com/binary-com/binary-static/pull/7293)
- **URLs**:
    - **w/ App ID + Server**: https://binary-static-git-fork-aizad-deriv-aizad-8168fix-derived-toggle.binary.sx/en/logged_inws.html?qa_server=frontend.binaryws.com&app_id=27964
    - **Original**: https://binary-static-git-fork-aizad-deriv-aizad-8168fix-derived-toggle.binary.sx/en/logged_inws.html
- **App ID**: `27964`

>
<span className={`icon synthetic_index ${open_accordion ? 'active' : ''}`} />
<span className={`icon synthetic_index ${subgroup_active ? 'active' : ''}`} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cant we write this similar to line 541 using classNames function

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resooolved 😩😩😩

>
<span className={`icon synthetic_index ${open_accordion ? 'active' : ''}`} />
<span className={`icon synthetic_index ${subgroup_active ? 'active' : ''}`} />
<span>{group_markets[item].markets[0].subgroup_name}</span>
<span className={`accordion-icon icon ${open_accordion ? 'active' : ''}`} />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resooolved 😩😩😩

@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

Copy link

@ameerul-deriv ameerul-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants