Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amina/comp 515/amend financial information dropdown #10360

Conversation

amina-deriv
Copy link
Contributor

@amina-deriv amina-deriv commented Sep 28, 2023

Changes:

This card is to remove the "Unemployed" from the occupation list when "Employed" is selected as Employment status.
image (6)

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Sep 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 26, 2023 6:10am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10360](https://github.com/binary-com/deriv-app/pull/10360)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-amina-deriv-amina-comp-515amendfinanc-8c617b.binary.sx?qa_server=red.derivws.com&app_id=24067
    - **Original**: https://deriv-app-git-fork-amina-deriv-amina-comp-515amendfinanc-8c617b.binary.sx
- **App ID**: `24067`

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟧 Best practices 83
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-amina-deriv-amina-comp-515amendfinanc-8c617b.binary.sx/

@coveralls
Copy link

coveralls commented Sep 28, 2023

Coverage Status

coverage: 26.923% (+0.1%) from 26.78% when pulling 0808b3d on amina-deriv:amina/COMP-515/amend_financial_information_dropdown into 4f51e97 on binary-com:master.

@gitguardian
Copy link

gitguardian bot commented Oct 3, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 3f11c80 nx.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

matin-deriv
matin-deriv previously approved these changes Oct 4, 2023
matin-deriv
matin-deriv previously approved these changes Oct 19, 2023
Copy link
Contributor

@matin-deriv matin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

matin-deriv
matin-deriv previously approved these changes Oct 25, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
3.6% 3.6% Duplication

@amina-deriv amina-deriv merged commit f6f566f into binary-com:master Oct 26, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants