-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amina/comp 515/amend financial information dropdown #10360
Amina/comp 515/amend financial information dropdown #10360
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-amina-deriv-amina-comp-515amendfinanc-8c617b.binary.sx/ |
…OMP-515/amend_financial_information_dropdown
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
- | Generic High Entropy Secret | 3f11c80 | nx.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
…OMP-515/amend_financial_information_dropdown
packages/account/src/Components/financial-details/financial-details-partials.tsx
Outdated
Show resolved
Hide resolved
packages/account/src/Sections/Assessment/FinancialAssessment/financial-assessment.tsx
Outdated
Show resolved
Hide resolved
…OMP-515/amend_financial_information_dropdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…OMP-515/amend_financial_information_dropdown
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Changes:
This card is to remove the "Unemployed" from the occupation list when "Employed" is selected as Employment status.
Screenshots:
Please provide some screenshots of the change.