Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kyc / wall-1551: CTA 'Next' button enhancement #10010

Conversation

yauheni-deriv
Copy link
Contributor

@yauheni-deriv yauheni-deriv commented Sep 8, 2023

Enabling 'Next' button for Personal, Address details pages, Financials assessment.
if there in unfilled required fields, clicking 'Next' button will scroll to this field.

@vercel
Copy link

vercel bot commented Sep 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 23, 2023 11:33am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10010](https://github.com/binary-com/deriv-app/pull/10010)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-yauheni-deriv-kyc-wall-1551ctanextbut-39b562.binary.sx?qa_server=red.binaryws.com&app_id=38674
    - **Original**: https://deriv-app-git-fork-yauheni-deriv-kyc-wall-1551ctanextbut-39b562.binary.sx
- **App ID**: `38674`

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with undefined

matin-deriv
matin-deriv previously approved these changes Oct 19, 2023
@coveralls
Copy link

Coverage Status

coverage: 26.284% (-0.002%) from 26.286% when pulling 2ee51b7 on yauheni-deriv:kyc/wall-1551/cta_next_button_enhancement into 649925b on binary-com:master.

@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
2.2% 2.2% Duplication

@matin-deriv matin-deriv merged commit 3b114c9 into binary-com:master Oct 26, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants