Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rupato/fix: added content search for different languages #10026

Conversation

rupato-deriv
Copy link
Contributor

@rupato-deriv rupato-deriv commented Sep 12, 2023

Changes:

  • Tutorials Tab
  • Added language search for different languages.
  • Refactored code for faq search and guide content arrays based on tab type.

Screenshots:

image

@vercel
Copy link

vercel bot commented Sep 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 3, 2023 2:59am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10026](https://github.com/binary-com/deriv-app/pull/10026)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-rupato-deriv-rupato-bot-584feature-au-c5d8f3.binary.sx?qa_server=red.binaryws.com&app_id=24068
    - **Original**: https://deriv-app-git-fork-rupato-deriv-rupato-bot-584feature-au-c5d8f3.binary.sx
- **App ID**: `24068`

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 86
🟧 Best practices 83
🟢 SEO 92
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-rupato-deriv-rupato-bot-584feature-au-c5d8f3.binary.sx/

@coveralls
Copy link

coveralls commented Sep 12, 2023

Coverage Status

coverage: 24.263% (-0.001%) from 24.264% when pulling a981182 on rupato-deriv:Rupato/BOT-584/Feature--autocomplete-for-tutorials-tab into 6cec2f2 on binary-com:master.

@gitguardian
Copy link

gitguardian bot commented Oct 3, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret e595535 nx.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
11.4% 11.4% Duplication

@rupato-deriv rupato-deriv changed the title fix: added content search for different languages Rupato/fix: added content search for different languages Oct 3, 2023
@sandeep-deriv sandeep-deriv merged commit ad3d38f into binary-com:master Oct 4, 2023
5 of 8 checks passed
vinu-deriv pushed a commit that referenced this pull request Oct 10, 2023
* fix: added content search for different languages

* fix: for clearing search values

* fix: for sonar cloud

* fix: trigger empty

* fix: for sonarcloud

* fix: trigger-circle-ci
vinu-deriv pushed a commit that referenced this pull request Oct 10, 2023
* fix: added content search for different languages

* fix: for clearing search values

* fix: for sonar cloud

* fix: trigger empty

* fix: for sonarcloud

* fix: trigger-circle-ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants