thisyahlen/chore: enforce camelcase #10308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-eslintcamelcase.binary.sx/ |
yashim-deriv
approved these changes
Sep 26, 2023
yashim-deriv
requested changes
Sep 26, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
yashim-deriv
approved these changes
Sep 27, 2023
| @@ -52,7 +52,7 @@ module.exports = { | |||
| 'sort-keys': 'warn', | |||
| 'typescript-sort-keys/interface': 'warn', | |||
| 'typescript-sort-keys/string-enum': 'warn', | |||
| camelcase: 'warn', | |||
| camelcase: 'error', | |||
| const location = useLocation(); | ||
|
|
||
| return ( | ||
| <WalletGradientBackground | ||
| currency={currency_config?.display_code || 'USD'} | ||
| currency={data?.currency_config?.display_code || 'USD'} |
There was a problem hiding this comment.
const { currency_config , currency, landing_company_name, ...} = data
There was a problem hiding this comment.
Because of the camelcase i am not destructuring.
vinu-deriv
pushed a commit
that referenced
this pull request
Oct 10, 2023
* chore: enforce camelcase * chore: fix circle ci and leftovers
vinu-deriv
pushed a commit
that referenced
this pull request
Oct 10, 2023
* chore: enforce camelcase * chore: fix circle ci and leftovers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.