Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hamza/Bug: CFDS 598/mt5 account type icons #10379

Conversation

hamza-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.
The MT5 icons are missing and incorrect MT5 account type is shown but the MT5 loginids are shown correctly from the real accounts

Screenshots:

Please provide some screenshots of the change.

image

image

@vercel
Copy link

vercel bot commented Sep 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 2, 2023 2:24am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10379](https://github.com/binary-com/deriv-app/pull/10379)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hamza-deriv-hamza-cfds-598mt5-account-7c715a.binary.sx?qa_server=red.binaryws.com&app_id=32194
    - **Original**: https://deriv-app-git-fork-hamza-deriv-hamza-cfds-598mt5-account-7c715a.binary.sx
- **App ID**: `32194`

@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 75
🟧 Best practices 83
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-hamza-deriv-hamza-cfds-598mt5-account-7c715a.binary.sx/

@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sandeep-deriv sandeep-deriv merged commit d63d134 into binary-com:master Oct 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants