Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

likhith/feat: 🎨 remove the sample images #10465

Merged
merged 7 commits into from
Oct 11, 2023
Merged

likhith/feat: 🎨 remove the sample images #10465

merged 7 commits into from
Oct 11, 2023

Conversation

likhith-deriv
Copy link
Contributor

Changes:

Removed the sample images provided since Example images are introduced

@vercel
Copy link

vercel bot commented Oct 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 4, 2023 5:44am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/10465](https://github.com/binary-com/deriv-app/pull/10465)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-likhith-deriv-likhith-wall-1118remove-b7a6fb.binary.sx?qa_server=red.binaryws.com&app_id=24182
    - **Original**: https://deriv-app-git-fork-likhith-deriv-likhith-wall-1118remove-b7a6fb.binary.sx
- **App ID**: `24182`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 20
🟧 Accessibility 75
🟧 Best practices 83
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-likhith-deriv-likhith-wall-1118remove-b7a6fb.binary.sx/

@coveralls
Copy link

coveralls commented Oct 3, 2023 •
edited
Loading

Coverage Status

coverage: 30.018% (+5.8%) from 24.268%
when pulling 3b15103 on likhith-deriv:likhith/WALL-1118/remove-sample-images
into bcaa4d8 on binary-com:master.

@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023 •
edited
Loading

⏳ Generating Lighthouse report...

matin-deriv
matin-deriv approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@matin-deriv matin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@vinu-deriv vinu-deriv merged commit c70bffc into binary-com:master Oct 11, 2023
7 checks passed
vinu-deriv pushed a commit that referenced this pull request Oct 17, 2023
@likhith-deriv @shahzaib-deriv @vinu-deriv
likhith/feat: 🎨 remove the sample images (#10465)
010bf8e 
* feat: 🎨 remove the sample images

* feat: 🎨 remove the sample images

* chore: Trigger Build

* fix: remove unused CSS

* chore: Trigger Build

---------

Co-authored-by: Shahzaib <shahzaib@deriv.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matin-deriv matin-deriv matin-deriv approved these changes

@amina-deriv amina-deriv amina-deriv approved these changes

@yauheni-deriv yauheni-deriv yauheni-deriv approved these changes

@shahzaib-deriv shahzaib-deriv shahzaib-deriv approved these changes

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv ali-hosseini-deriv is a code owner

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv maryia-deriv is a code owner

Assignees
No one assigned
Labels
Account Core Shared
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@likhith-deriv @coveralls @matin-deriv @amina-deriv @yauheni-deriv @shahzaib-deriv @vinu-deriv