Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set global-require eslint rule to off #10506

Merged

Conversation

shahzaib-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 5, 2023 6:24am

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@shahzaib-deriv shahzaib-deriv changed the title chore: set global-require eslint rule to off set global-require eslint rule to off Oct 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10506](https://github.com/binary-com/deriv-app/pull/10506)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shahzaib-deriv-eslint-global-require-rule.binary.sx?qa_server=red.binaryws.com&app_id=32109
    - **Original**: https://deriv-app-git-fork-shahzaib-deriv-eslint-global-require-rule.binary.sx
- **App ID**: `32109`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 19
🟧 Accessibility 75
🟧 Best practices 83
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-shahzaib-deriv-eslint-global-require-rule.binary.sx/

Copy link
Member

@ali-hosseini-deriv ali-hosseini-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandeep-deriv sandeep-deriv merged commit 76366c9 into binary-com:master Oct 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants