Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Likhith/kyc 363/onfido sdk updation #10560

Merged
merged 264 commits into from
Nov 9, 2023
Merged

Likhith/kyc 363/onfido sdk updation #10560

merged 264 commits into from
Nov 9, 2023

Conversation

likhith-deriv
Copy link
Contributor

Changes:

  • Upgraded Onfido-ui-sdk from 11.0.0 to 13.3.1
  • Incorporated language change of Onfido SDK
  • Moved API calls to hooks
  • Created a utility function to convert Language codes for Onfido SDK

“yauheni-kryzhyk-deriv” and others added 30 commits June 7, 2023 09:46
refactor: review comments
4cea8ce
refactor: review comments css
feec7ee
@likhith-deriv
fix: 🐛 incorporated message to display document type
9251eac
@likhith-deriv
fix: resolved code smell
25f1428
@likhith-deriv
fix: 🐛 incorporated generic error message
5f5ff9f
@likhith-deriv
Merge branch 'master' into combined/wall-400/IDV-error-message-handled
4da3cf4
@likhith-deriv
fix: 🐛 added missing dependency
8a854c8
@likhith-deriv
chore: 🔀 synced with master
7b7162d
@likhith-deriv
Merge branch 'master' into combined/wall-400/IDV-error-message-handled
d85dfdd
@likhith-deriv
Merge branch 'master' into combined/wall-400/IDV-error-message-handled
9b7045e
@likhith-deriv
Merge branch 'master' into combined/wall-400/IDV-error-message-handled
6bed18e
@likhith-deriv
Merge branch 'master' into combined/wall-400/IDV-error-message-handled
87e7f22
@likhith-deriv
fix: ♻️ incorporated review comments
b6d4a5d
@yauheni-deriv
Merge branch 'master' into combined/wall-400/IDV-error-message-handled
0086aac
@likhith-deriv
fix: resolved un necessary render issue
93faee8
fix: resolve conflicts, update from master
77a2f8a
@likhith-deriv
fix: 🐛 resolved issue with expired status
df673be
@yauheni-deriv
Merge branch 'master' into combined/wall-400/IDV-error-message-handled
35ff78f
@shahzaib-deriv
style: fix side container width in poi (#39)
d5b5228
@shahzaib-deriv
style: container height fix for POI error messages when content in no…
524a24a 
…t overflowing (#40)
fix: onfido message alignment
3081a65
@likhith-deriv
fix: 🐛 incorporated continue trade button
a856c79
fix: onfido page mobile
c15a225
@shahzaib-deriv
style: no padding on fields container in idv screen (#41)
98bb54a
@yauheni-deriv
Merge branch 'master' into combined/wall-400/IDV-error-message-handled
74435a9
refactor: onfido hint center alignment fix
b1542ae
fix: odd translate value fix
f49eae8
@likhith-deriv
fix: 🐛 minor CSS fix
4d7b8e3
fix: green message responsive position
fdc0b9e
fix: green message full width
3880f11
@boring-cyborg boring-cyborg bot added the Core label Nov 8, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

❌ Smoke test run (1) failed. See logs for details: Visit Action

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
28.0% 28.0% Duplication

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

🚀 Smoke test run (1) passed successfully!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

🚀 Smoke test run (2) passed successfully!

@likhith-deriv likhith-deriv merged commit 065ed72 into binary-com:master Nov 9, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matin-deriv matin-deriv matin-deriv approved these changes

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv ali-hosseini-deriv is a code owner

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv maryia-deriv is a code owner

@mahdiyeh-deriv mahdiyeh-deriv Awaiting requested review from mahdiyeh-deriv

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv

@amina-deriv amina-deriv Awaiting requested review from amina-deriv amina-deriv is a code owner

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

@wojciech-deriv wojciech-deriv Awaiting requested review from wojciech-deriv wojciech-deriv is a code owner

@thisyahlen-deriv thisyahlen-deriv Awaiting requested review from thisyahlen-deriv

@farhan-nurzi-deriv farhan-nurzi-deriv Awaiting requested review from farhan-nurzi-deriv

@adrienne-deriv adrienne-deriv Awaiting requested review from adrienne-deriv

Assignees
No one assigned
Labels
Account Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@likhith-deriv @coveralls @matin-deriv @yauheni-deriv @shahzaib-deriv