Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[42069] Aizad: Creating Base Button for Wallets #10649

Merged
merged 7 commits into from
Oct 13, 2023
Merged

[42069] Aizad: Creating Base Button for Wallets #10649

merged 7 commits into from
Oct 13, 2023

Conversation

aizad-deriv
Copy link
Contributor

@aizad-deriv aizad-deriv commented Oct 13, 2023 •
edited
Loading

Changes:

Please provide a summary of the change.

  • Create a WalletButton component.
  • Replacing existing button with the new component.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Oct 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 13, 2023 8:37am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/10649](https://github.com/binary-com/deriv-app/pull/10649)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aizad-deriv-aizad-wallet-button.binary.sx?qa_server=red.binaryws.com&app_id=24087
    - **Original**: https://deriv-app-git-fork-aizad-deriv-aizad-wallet-button.binary.sx
- **App ID**: `24087`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-wallet-button.binary.sx/

wojciech-deriv
wojciech-deriv reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@wojciech-deriv wojciech-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is actually used or is gonna be used anytime soon?

wojciech-deriv
wojciech-deriv previously approved these changes Oct 13, 2023
View reviewed changes
wojciech-deriv
wojciech-deriv previously approved these changes Oct 13, 2023
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wojciech-deriv wojciech-deriv merged commit b79c9f8 into binary-com:master Oct 13, 2023
7 checks passed
vinu-deriv pushed a commit that referenced this pull request Oct 17, 2023
@aizad-deriv @vinu-deriv
[42069] Aizad: Creating Base Button for Wallets (#10649)
4f94830 
* chore: create base button component for wallets

* chore: replace some of the components with WalletButton and added extra props

* fix: added more components with WalletButton and WalletText

* fix: resolve comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisyahlen-deriv thisyahlen-deriv thisyahlen-deriv approved these changes

@farhan-nurzi-deriv farhan-nurzi-deriv farhan-nurzi-deriv approved these changes

@wojciech-deriv wojciech-deriv wojciech-deriv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aizad-deriv @thisyahlen-deriv @farhan-nurzi-deriv @wojciech-deriv