shahzaib / KYC-805 / remove expiry date for nimc slip from manual upload screen #10702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzaib-deriv
requested review from
matin-deriv,
amina-deriv and
maryia-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-shahzaib-deriv-kyc-805-remove-expiry-03e0e5.binary.sx/ |
shahzaib-deriv
changed the title
…nimc-on-manual-upload-page
shaheer-deriv
approved these changes
Oct 17, 2023
packages/account/src/Components/poi/status/unsupported/card-details/utils.ts
Outdated
Show resolved
Hide resolved
suisin-deriv
approved these changes
Oct 17, 2023
likhith-deriv
approved these changes
Oct 17, 2023
matin-deriv
previously approved these changes
Oct 18, 2023
thisyahlen-deriv
previously approved these changes
Oct 19, 2023
…nimc-on-manual-upload-page
shahzaib-deriv
had a problem deploying
to
Preview
GitHub Actions
Failure
…nimc-on-manual-upload-page
shahzaib-deriv
dismissed stale reviews from thisyahlen-deriv and matin-deriv
via
f3ff43c
|
Kudos, SonarCloud Quality Gate passed!
|
packages/account/src/Components/poi/status/unsupported/card-details/utils.ts
Show resolved
Hide resolved
packages/account/src/Components/poi/status/unsupported/card-details/card-details.scss
Show resolved
Hide resolved
yauheni-deriv
approved these changes
Oct 20, 2023
likhith-deriv
approved these changes
Oct 20, 2023
matin-deriv
approved these changes
Oct 22, 2023
amina-deriv
approved these changes
Oct 23, 2023
aum-deriv
pushed a commit
to aum-deriv/deriv-app
that referenced
this pull request
Oct 23, 2023
…oad screen (binary-com#10702) * chore: remove expiry date for nimc slip from manaul upload screen * chore: update margin between fields * fix: update field name in uploader utils * chore: max character validation for input in manual upload screen * style: update manual upload screen paddings for responsive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR focuses on removing
Expiry Datefield for NIMC slip selection as NIMC slip doesn't have any expiration date.Also the hint about valid document is removed.
Screenshots:
Before:
After: