[69420] Refactor account ready modal to success modal #10740

adrienne-deriv · 2023-10-17T06:38:15Z

Changes:

Please provide a summary of the change.

Made account ready modal to be generic
Renamed account ready to success

Screenshots:

Please provide some screenshots of the change.

vercel · 2023-10-17T06:38:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Oct 18, 2023 7:28am

adrienne-deriv · 2023-10-17T06:39:51Z

packages/wallets/src/features/cfd/screens/Success/Success.tsx

+    description: string;
+    marketType: Exclude<NonNullable<ReturnType<typeof useSortedMT5Accounts>['data']>[number]['market_type'], undefined>;
+    renderButton: () => ReactNode;
+    title: string;


Made success modal to render the buttons, because there can be alot of button variants:

…app into succes-modal-props

github-actions · 2023-10-17T06:42:33Z

A production App ID was automatically generated for this PR. (log)

PR: [69420] Refactor account ready modal to success modal #10740
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-adrienne-deriv-succes-modal-props.binary.sx?qa_server=red.binaryws.com&app_id=23804
- Original: https://deriv-app-git-fork-adrienne-deriv-succes-modal-props.binary.sx
App ID: 23804

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/10740](https://github.com/binary-com/deriv-app/pull/10740)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-adrienne-deriv-succes-modal-props.binary.sx?qa_server=red.binaryws.com&app_id=23804
    - **Original**: https://deriv-app-git-fork-adrienne-deriv-succes-modal-props.binary.sx
- **App ID**: `23804`

github-actions · 2023-10-17T06:42:45Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	15
🟧 Accessibility	88
🟢 Best practices	92
🟢 SEO	92
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-adrienne-deriv-succes-modal-props.binary.sx/

thisyahlen-deriv · 2023-10-17T06:46:56Z

packages/wallets/src/features/cfd/screens/Success/Success.tsx

+                <div className='wallets-success__info__text--type'>
+                    {marketTypeToTitleMapper[marketType]} ({landingCompanyName})
+                </div>
+                <div className='wallets-success__info__text--wallet'>{data?.currency} Wallet</div>


Can wrap this with WalletText

thisyahlen-deriv · 2023-10-17T06:47:03Z

packages/wallets/src/features/cfd/screens/Success/Success.tsx

+                    {marketTypeToTitleMapper[marketType]} ({landingCompanyName})
+                </div>
+                <div className='wallets-success__info__text--wallet'>{data?.currency} Wallet</div>
+                <div className='wallets-success__info__text--amount'>{data?.display_balance} USD</div>


coveralls · 2023-10-17T06:56:28Z

coverage: 25.961%. remained the same when pulling 9b09f0f on adrienne-deriv:succes-modal-props into 6d8fa27 on binary-com:master.

packages/wallets/src/features/cfd/screens/Success/Success.tsx

…modal-props

...ages/wallets/src/features/cfd/modals/DxtradeEnterPasswordModal/DxtradeEnterPasswordModal.tsx

packages/wallets/src/features/cfd/components/CTraderList/CTraderList.tsx

…modal-props

packages/wallets/src/features/cfd/modals/JurisdictionModal/JurisdictionModal.tsx

…modal-props

sonarcloud · 2023-10-18T07:19:10Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

adrienne-deriv added 2 commits October 17, 2023 13:55

chore: backup

ca0c82a

refactor: renamed account ready modal to success modal

5f6b128

refactor: renamed account ready modal to success modal

7560206

adrienne-deriv deployed to Preview October 17, 2023 06:39 — with GitHub Actions View deployment

adrienne-deriv commented Oct 17, 2023

View reviewed changes

adrienne-deriv marked this pull request as ready for review October 17, 2023 06:39

adrienne-deriv requested a review from wojciech-deriv as a code owner October 17, 2023 06:39

Merge branch 'succes-modal-props' of github.com:adrienne-deriv/deriv-…

857efb5

…app into succes-modal-props

adrienne-deriv deployed to Preview October 17, 2023 06:42 — with GitHub Actions View deployment

thisyahlen-deriv reviewed Oct 17, 2023

View reviewed changes

chore: used wallet text, waiting for line height

747c5d2

adrienne-deriv deployed to Preview October 17, 2023 07:09 — with GitHub Actions View deployment

chore: removed unused css

564768b

adrienne-deriv deployed to Preview October 17, 2023 07:20 — with GitHub Actions View deployment

arshad-rao-deriv reviewed Oct 17, 2023

View reviewed changes

packages/wallets/src/features/cfd/screens/Success/Success.tsx Outdated Show resolved Hide resolved

adrienne-deriv added 2 commits October 18, 2023 11:49

chore: backup before merge

acb2a71

Merge branch 'master' of github.com:binary-com/deriv-app into succes-…

2ee05f8

…modal-props

adrienne-deriv deployed to Preview October 18, 2023 06:09 — with GitHub Actions View deployment

adrienne-deriv commented Oct 18, 2023

View reviewed changes

...ages/wallets/src/features/cfd/modals/DxtradeEnterPasswordModal/DxtradeEnterPasswordModal.tsx Show resolved Hide resolved

adrienne-deriv commented Oct 18, 2023

View reviewed changes

packages/wallets/src/features/cfd/components/CTraderList/CTraderList.tsx Show resolved Hide resolved

thisyahlen-deriv approved these changes Oct 18, 2023

View reviewed changes

chore: fix eslint types

e5cfcac

adrienne-deriv deployed to Preview October 18, 2023 06:28 — with GitHub Actions View deployment

adrienne-deriv added 2 commits October 18, 2023 14:29

Merge branch 'master' of github.com:binary-com/deriv-app into succes-…

4452bd8

…modal-props

chore: fix eslint types

9b09f0f

adrienne-deriv deployed to Preview October 18, 2023 06:32 — with GitHub Actions View deployment

arshad-rao-deriv reviewed Oct 18, 2023

View reviewed changes

packages/wallets/src/features/cfd/modals/JurisdictionModal/JurisdictionModal.tsx Show resolved Hide resolved

chore: fix issue where svg has checkbox jurisdiction

65da29e

adrienne-deriv deployed to Preview October 18, 2023 06:52 — with GitHub Actions View deployment

Merge branch 'master' of github.com:binary-com/deriv-app into succes-…

838a5dc

…modal-props

adrienne-deriv deployed to Preview October 18, 2023 07:07 — with GitHub Actions View deployment

chore: fix eslint sort issue

0b3e209

adrienne-deriv deployed to Preview October 18, 2023 07:16 — with GitHub Actions View deployment

yashim-deriv approved these changes Oct 18, 2023

View reviewed changes

yashim-deriv merged commit 01398de into binary-com:master Oct 18, 2023
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[69420] Refactor account ready modal to success modal #10740

[69420] Refactor account ready modal to success modal #10740

adrienne-deriv commented Oct 17, 2023 •

edited

Loading

vercel bot commented Oct 17, 2023 •

edited

Loading

adrienne-deriv Oct 17, 2023

github-actions bot commented Oct 17, 2023 •

edited

Loading

github-actions bot commented Oct 17, 2023 •

edited

Loading

thisyahlen-deriv Oct 17, 2023

thisyahlen-deriv Oct 17, 2023

coveralls commented Oct 17, 2023 •

edited

Loading

sonarcloud bot commented Oct 18, 2023

[69420] Refactor account ready modal to success modal #10740

[69420] Refactor account ready modal to success modal #10740

Conversation

adrienne-deriv commented Oct 17, 2023 • edited Loading

Changes:

Screenshots:

vercel bot commented Oct 17, 2023 • edited Loading

adrienne-deriv Oct 17, 2023

Choose a reason for hiding this comment

github-actions bot commented Oct 17, 2023 • edited Loading

github-actions bot commented Oct 17, 2023 • edited Loading

thisyahlen-deriv Oct 17, 2023

Choose a reason for hiding this comment

thisyahlen-deriv Oct 17, 2023

Choose a reason for hiding this comment

coveralls commented Oct 17, 2023 • edited Loading

sonarcloud bot commented Oct 18, 2023

adrienne-deriv commented Oct 17, 2023 •

edited

Loading

vercel bot commented Oct 17, 2023 •

edited

Loading

github-actions bot commented Oct 17, 2023 •

edited

Loading

github-actions bot commented Oct 17, 2023 •

edited

Loading

coveralls commented Oct 17, 2023 •

edited

Loading