[DTRA] / Kate / DTRA-420 / [Package 7] Tech debt: TS migration + Refactoring #10848

kate-deriv · 2023-10-20T12:21:44Z

Changes:

This parent brach will contain mainly TS migration + refactoring of trade.jsx, init-store.js, contract.jsx, contract-replay.jsx and duration files.

Screenshots:

Please provide some screenshots of the change.

vercel · 2023-10-20T12:21:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Dec 11, 2023 2:14pm

coveralls · 2023-10-20T12:33:56Z

coverage: 30.557% (-0.06%) from 30.618%
when pulling 0af3108 on kate-deriv:kate/DTRA-420/ts_migration_7
into 44861a9 on binary-com:master.

github-actions · 2023-10-20T12:40:09Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	17
🟧 Accessibility	75
🟢 Best practices	92
🟢 SEO	92
🟧 PWA	80

Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-dtra-420tsmigration7.binary.sx/

…ader package (#43) * refactor: ts of expity text * refactor: ts of duration toggle * refactor: ts of simple duration * fix: types * feat: ts of duration wrapper * refactor: ts of daration * refactor: add ts for advanced duration * refactor: ts of duration mobile * refactor: unit test * refactor: apply suggestions * chore: add fallback for simple duration unit * refactor: apply suggestions * chore: refactor type

github-actions · 2023-10-25T08:29:17Z

A production App ID was automatically generated for this PR. (log)

PR: [DTRA] / Kate / DTRA-420 / [Package 7] Tech debt: TS migration + Refactoring #10848
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-kate-deriv-kate-dtra-420tsmigration7.binary.sx?qa_server=red.derivws.com&app_id=24072
- Original: https://deriv-app-git-fork-kate-deriv-kate-dtra-420tsmigration7.binary.sx
App ID: 24072

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/10848](https://github.com/binary-com/deriv-app/pull/10848)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-kate-deriv-kate-dtra-420tsmigration7.binary.sx?qa_server=red.derivws.com&app_id=24072
    - **Original**: https://deriv-app-git-fork-kate-deriv-kate-dtra-420tsmigration7.binary.sx
- **App ID**: `24072`

…ackage (#44) * refactor: ts of contract file * refactor: ts of contract replay * refactor: add more types for contract store * chore: expand type * refactor: apply suggestions * refactor: separate replay chart from contract replay * refactor: add ternary rendering * fix: revert latest changes

packages/trader/src/Modules/Contract/Containers/contract-replay.tsx

github-actions · 2023-12-06T08:43:27Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-12-06T08:45:46Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-12-06T08:45:54Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-12-11T06:49:16Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-12-11T06:49:18Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-12-11T06:49:35Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-12-11T06:49:36Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-12-11T07:05:47Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-12-11T07:05:51Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-12-11T13:57:43Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-12-11T13:57:44Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-12-11T13:58:02Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-12-11T13:58:03Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

sonarcloud · 2023-12-11T14:01:05Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
19 Code Smells

No Coverage information
0.0% Duplication

github-actions · 2023-12-11T14:14:40Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-12-11T14:14:44Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-12-11T14:18:18Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

github-actions · 2023-12-11T14:18:24Z

⏳ Generating Lighthouse report...

chore: empty commit

81130e7

kate-deriv deployed to Preview October 20, 2023 12:22 — with GitHub Actions View deployment

kate-deriv changed the title ~~Kate / DTRA-420 / [Package 7] Tech debt TS migration~~ Kate / DTRA-420 / [Package 7] Tech debt: TS migration Oct 20, 2023

kate-deriv changed the title ~~Kate / DTRA-420 / [Package 7] Tech debt: TS migration~~ Kate / DTRA-420 / [Package 7] Tech debt: TS migration + Refactoring Oct 20, 2023

kate-deriv requested review from matin-deriv, maryia-deriv and ali-hosseini-deriv as code owners October 25, 2023 08:28

boring-cyborg bot added Components Shared Trader labels Oct 25, 2023

kate-deriv had a problem deploying to Preview October 25, 2023 08:29 — with GitHub Actions Failure

Merge branch 'master' into kate/DTRA-420/ts_migration_7

9330ffd

kate-deriv had a problem deploying to Preview October 25, 2023 08:41 — with GitHub Actions Failure

refactor: remove code smells

8343d73

kate-deriv deployed to Preview October 25, 2023 09:03 — with GitHub Actions View deployment

Merge branch master into kate/DTRA-420/ts_migration_7

d9dabeb

kate-deriv deployed to Preview October 25, 2023 11:51 — with GitHub Actions View deployment

kate-deriv deployed to Preview October 30, 2023 09:00 — with GitHub Actions View deployment

kate-deriv commented Oct 30, 2023

View reviewed changes

packages/trader/src/Modules/Contract/Containers/contract-replay.tsx Outdated Show resolved Hide resolved

refactor: remove code smells

48fca5f

kate-deriv deployed to Preview October 30, 2023 14:12 — with GitHub Actions View deployment

Merge branch 'binary-com:master' into kate/DTRA-420/ts_migration_7

e7dc4e8

kate-deriv deployed to Preview October 30, 2023 14:35 — with GitHub Actions View deployment

Merge branch master into kate/DTRA-420/ts_migration_7

a126c22

balakrishna-deriv previously approved these changes Dec 7, 2023

View reviewed changes

Merge branch master into kate/DTRA-420/ts_migration_7

3cf4c4b

kate-deriv dismissed stale reviews from balakrishna-deriv and maryia-deriv via 3cf4c4b December 11, 2023 06:48

kate-deriv temporarily deployed to Preview December 11, 2023 06:49 — with GitHub Actions Inactive

chore: remove extra ui mocked prop

0af3108

kate-deriv temporarily deployed to Preview December 11, 2023 13:57 — with GitHub Actions Inactive

maryia-deriv approved these changes Dec 11, 2023

View reviewed changes

balakrishna-deriv approved these changes Dec 12, 2023

View reviewed changes

balakrishna-deriv merged commit ee4601b into binary-com:master Dec 12, 2023
6 of 7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DTRA] / Kate / DTRA-420 / [Package 7] Tech debt: TS migration + Refactoring #10848

[DTRA] / Kate / DTRA-420 / [Package 7] Tech debt: TS migration + Refactoring #10848

kate-deriv commented Oct 20, 2023 •

edited

Loading

vercel bot commented Oct 20, 2023 •

edited

Loading

coveralls commented Oct 20, 2023 •

edited

Loading

github-actions bot commented Oct 20, 2023 •

edited

Loading

github-actions bot commented Oct 25, 2023 •

edited

Loading

github-actions bot commented Dec 6, 2023

github-actions bot commented Dec 6, 2023

github-actions bot commented Dec 6, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

sonarcloud bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

[DTRA] / Kate / DTRA-420 / [Package 7] Tech debt: TS migration + Refactoring #10848

[DTRA] / Kate / DTRA-420 / [Package 7] Tech debt: TS migration + Refactoring #10848

Conversation

kate-deriv commented Oct 20, 2023 • edited Loading

Changes:

Screenshots:

vercel bot commented Oct 20, 2023 • edited Loading

coveralls commented Oct 20, 2023 • edited Loading

github-actions bot commented Oct 20, 2023 • edited Loading

github-actions bot commented Oct 25, 2023 • edited Loading

github-actions bot commented Dec 6, 2023

github-actions bot commented Dec 6, 2023

github-actions bot commented Dec 6, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

sonarcloud bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

github-actions bot commented Dec 11, 2023

kate-deriv commented Oct 20, 2023 •

edited

Loading

vercel bot commented Oct 20, 2023 •

edited

Loading

coveralls commented Oct 20, 2023 •

edited

Loading

github-actions bot commented Oct 20, 2023 •

edited

Loading

github-actions bot commented Oct 25, 2023 •

edited

Loading