Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wallet] aum / WALL-2271 / fix-ui-crypto-deposit #10850

Merged
merged 13 commits into from
Oct 25, 2023
Merged

[Wallet] aum / WALL-2271 / fix-ui-crypto-deposit #10850

merged 13 commits into from
Oct 25, 2023

Conversation

aum-deriv
Copy link
Contributor

@aum-deriv aum-deriv commented Oct 20, 2023 •
edited
Loading

Changes:

Fixed the following UI inconsistencies for the crypto-deposit page for both desktop & responsive:

  • All the font-sizes.
  • Size of the QR code.
  • Gaps between the elements.
  • Position of the note.

Screenshots:

Screenshot 2023-10-23 at 3 50 56 PM

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Oct 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 25, 2023 5:23am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/10850](https://github.com/binary-com/deriv-app/pull/10850)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aum-deriv-aum-wall-2271fix-ui-crypto-deposit.binary.sx?qa_server=red.binaryws.com&app_id=24075
    - **Original**: https://deriv-app-git-fork-aum-deriv-aum-wall-2271fix-ui-crypto-deposit.binary.sx
- **App ID**: `24075`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-aum-deriv-aum-wall-2271fix-ui-crypto-deposit.binary.sx/

@aum-deriv aum-deriv marked this pull request as ready for review October 23, 2023 11:43
nijil-deriv
nijil-deriv previously approved these changes Oct 24, 2023
View reviewed changes
yashim-deriv
yashim-deriv previously approved these changes Oct 24, 2023
View reviewed changes
adrienne-deriv
adrienne-deriv requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

px to rem

adrienne-deriv
adrienne-deriv previously approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Oct 24, 2023 •
edited
Loading

Coverage Status

coverage: 26.72%. remained the same when pulling e5c4d0b on aum-deriv:aum/WALL-2271/fix-ui-crypto-deposit into e5e1158 on binary-com:master.

adrienne-deriv
adrienne-deriv requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adrienne-deriv
adrienne-deriv previously approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.0% 8.0% Duplication

@nijil-deriv nijil-deriv merged commit f1653a3 into binary-com:master Oct 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nijil-deriv nijil-deriv nijil-deriv approved these changes

@mahdiyeh-deriv mahdiyeh-deriv mahdiyeh-deriv approved these changes

@aizad-deriv aizad-deriv aizad-deriv approved these changes

@thisyahlen-deriv thisyahlen-deriv thisyahlen-deriv approved these changes

@farhan-nurzi-deriv farhan-nurzi-deriv farhan-nurzi-deriv approved these changes

@adrienne-deriv adrienne-deriv adrienne-deriv left review comments

@wojciech-deriv wojciech-deriv Awaiting requested review from wojciech-deriv wojciech-deriv is a code owner

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@aum-deriv @coveralls @nijil-deriv @yashim-deriv @mahdiyeh-deriv @adrienne-deriv @aizad-deriv @thisyahlen-deriv @farhan-nurzi-deriv