Shontzu/cfds 1176/wrong content for dxtrade password regression #10934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shontzu-deriv
requested review from
hirad-deriv and
matin-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…e-password-regression
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-shontzu-deriv-shontzu-cfds-1176wrong-527fac.binary.sx/ |
|
Kudos, SonarCloud Quality Gate passed!
|
hamza-deriv
approved these changes
Oct 25, 2023
hirad-deriv
approved these changes
Oct 25, 2023
bahar-sadeghzadeh
pushed a commit
that referenced
this pull request
Oct 25, 2023
* fix: fixed typo causing misleading description * chore: password modal label for dxtrade (CFD -> Real)
likhith-deriv
pushed a commit
to likhith-deriv/deriv-app
that referenced
this pull request
Oct 25, 2023
…ry-com#10934) * fix: fixed typo causing misleading description * chore: password modal label for dxtrade (CFD -> Real)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: text change for password modal of derivX real
in password modal to get derivX, the text should follow:
no existing demo or deal derivx account: "You can use this password for all your Deriv X accounts."
has existing real, get demo derivx: "Enter your Deriv X password to add a Deriv X account."
has existing demo, get real derivx: "Enter your Deriv X password to add a Deriv X Real account."
