Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thisyahlen/showing wallets subtasks #10970

Merged
merged 11 commits into from
Oct 26, 2023
Merged

Thisyahlen/showing wallets subtasks #10970

merged 11 commits into from
Oct 26, 2023

Conversation

thisyahlen-deriv
Copy link
Contributor

@thisyahlen-deriv thisyahlen-deriv commented Oct 26, 2023 •
edited
Loading

Changes:

Please provide a summary of the change.

  1. Add routing to external platform [smarttrader and binarybot)
  2. Add routing to deriv com links (dmt5, derivgo)

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Oct 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 26, 2023 7:36am

@coveralls
Copy link

Coverage Status

coverage: 26.783%. remained the same when pulling a190bc4 on thisyahlen-deriv:thisyahlen/showing_wallets_subtasks into 0e2f074 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/10970](https://github.com/binary-com/deriv-app/pull/10970)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-showingwa-6f2d2b.binary.sx?qa_server=red.derivws.com&app_id=32187
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-showingwa-6f2d2b.binary.sx
- **App ID**: `32187`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-showingwa-6f2d2b.binary.sx/

@mahdiyeh-deriv
Copy link
Contributor

@thisyahlen-deriv LGTM , just raised a subtask https://app.clickup.com/t/20696747/WALL-2332

@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 7 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@yashim-deriv yashim-deriv merged commit b7834f1 into binary-com:master Oct 26, 2023
5 of 6 checks passed
aum-deriv pushed a commit to aum-deriv/deriv-app that referenced this pull request Oct 26, 2023
@thisyahlen-deriv @aum-deriv
thisyahlen/feat: showing wallets subtasks (binary-com#10970)
590db85 
* chore: update proper type and cleanup

* chore: cleanup

* chore: add more proper types

* chore: add url routing for external platform

* chore: update links to mt5 and derivx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashim-deriv yashim-deriv yashim-deriv approved these changes

@mahdiyeh-deriv mahdiyeh-deriv mahdiyeh-deriv approved these changes

@farhan-nurzi-deriv farhan-nurzi-deriv farhan-nurzi-deriv approved these changes

@adrienne-deriv adrienne-deriv Awaiting requested review from adrienne-deriv adrienne-deriv is a code owner

@wojciech-deriv wojciech-deriv Awaiting requested review from wojciech-deriv wojciech-deriv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thisyahlen-deriv @coveralls @mahdiyeh-deriv @yashim-deriv @farhan-nurzi-deriv