Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEBREL-1574 / remove defaultChecked prop from checkbox #10982

Conversation

shahzaib-deriv
Copy link
Contributor

Changes:

This PR focuses on removing defaultChecked from the checkbox in components package to remove console error related to controlled & uncontrolled form.
Having checked & defaultChecked prop at the same time creates an error by React.

Screenshots:

Screenshot 2023-10-26 at 4 02 14 PM

@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 26, 2023 9:19am

@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10982](https://github.com/binary-com/deriv-app/pull/10982)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shahzaib-deriv-webrel-1574-fix-checkb-30544d.binary.sx?qa_server=red.derivws.com&app_id=23804
    - **Original**: https://deriv-app-git-fork-shahzaib-deriv-webrel-1574-fix-checkb-30544d.binary.sx
- **App ID**: `23804`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-shahzaib-deriv-webrel-1574-fix-checkb-30544d.binary.sx/

@maryia-deriv maryia-deriv merged commit a0b609f into binary-com:master Oct 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants