Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aizad/WALL-2439/Created Icon Button Component #11153

Merged

Conversation

aizad-deriv
Copy link
Contributor

Changes:

  • Created Icon Button component

Screenshots:

Screenshot 2023-11-03 at 12 34 36 PM

Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 3, 2023 6:52am

@coveralls
Copy link

coveralls commented Nov 3, 2023

Coverage Status

coverage: 26.43% (-0.008%) from 26.438%
when pulling cfde31f on aizad-deriv:aizad/WALL-2439/wallet-icon
into 2d4df12 on binary-com:master.

Copy link
Contributor

github-actions bot commented Nov 3, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11153](https://github.com/binary-com/deriv-app/pull/11153)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aizad-deriv-aizad-wall-2439wallet-icon.binary.sx?qa_server=red.derivws.com&app_id=23825
    - **Original**: https://deriv-app-git-fork-aizad-deriv-aizad-wall-2439wallet-icon.binary.sx
- **App ID**: `23825`

Copy link
Contributor

github-actions bot commented Nov 3, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-wall-2439wallet-icon.binary.sx/

mahdiyeh-deriv
mahdiyeh-deriv previously approved these changes Nov 3, 2023
@aizad-deriv aizad-deriv changed the title feat: Created Icon Button for wallets package Aizad/WALL-2439/Created Icon Button Component Nov 3, 2023
Copy link
Contributor

@farhan-nurzi-deriv farhan-nurzi-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused imports. The rest LGTM 👍

Copy link

sonarcloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

github-actions bot commented Nov 3, 2023

🚀 Smoke test run (2) passed successfully!

Copy link
Contributor

github-actions bot commented Nov 3, 2023

🚀 Smoke test run (1) passed successfully!

@mahdiyeh-deriv mahdiyeh-deriv merged commit 641035b into binary-com:master Nov 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants