[CFDs] Hirad/ Adding the current_list hook #11358

hirad-deriv · 2023-11-13T06:20:02Z

Changes:

Adding the current_list hook

Screenshots:

vercel · 2023-11-13T06:20:07Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Nov 17, 2023 5:05am

github-actions · 2023-11-13T06:35:34Z

A production App ID was automatically generated for this PR. (log)

PR: [CFDs] Hirad/ Adding the current_list hook #11358
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-hirad-deriv-hirad-cfds-1399currentlisthook.binary.sx?qa_server=red.derivws.com&app_id=23881
- Original: https://deriv-app-git-fork-hirad-deriv-hirad-cfds-1399currentlisthook.binary.sx
App ID: 23881

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/11358](https://github.com/binary-com/deriv-app/pull/11358)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hirad-deriv-hirad-cfds-1399currentlisthook.binary.sx?qa_server=red.derivws.com&app_id=23881
    - **Original**: https://deriv-app-git-fork-hirad-deriv-hirad-cfds-1399currentlisthook.binary.sx
- **App ID**: `23881`

github-actions · 2023-11-13T06:36:26Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	16
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟧 PWA	80

Lighthouse ran with https://deriv-app-git-fork-hirad-deriv-hirad-cfds-1399currentlisthook.binary.sx/

coveralls · 2023-11-13T08:33:10Z

coverage: 27.758% (-0.004%) from 27.762%
when pulling 12e7f6b on hirad-deriv:Hirad/CFDs-1399/current_list_hook
into 6689651 on binary-com:master.

thisyahlen-deriv · 2023-11-14T03:46:05Z

packages/cfd/src/Components/props.types.ts

@@ -7,6 +7,8 @@ export type TCFDPlatform = 'dxtrade' | 'mt5' | 'ctrader' | 'derivez';

 export type TCFDsPlatformType = 'dxtrade' | 'derivez' | 'mt5' | 'ctrader' | '';

+export type TShortcode = 'svg' | 'bvi' | 'labuan' | 'vanuatu' | 'maltainvest';


We can get the types from the api itself.

We have a redundant Shortcode in the API (seychelles). I can either get it from the API and Omit that type or just hard code it myself. Let me check the api types one more time

You can use Partial or DeepPartial if you face errors

hamza-deriv · 2023-11-14T03:46:23Z

packages/cfd/src/Components/props.types.ts

@@ -7,6 +7,8 @@ export type TCFDPlatform = 'dxtrade' | 'mt5' | 'ctrader' | 'derivez';

 export type TCFDsPlatformType = 'dxtrade' | 'derivez' | 'mt5' | 'ctrader' | '';

+export type TShortcode = 'svg' | 'bvi' | 'labuan' | 'vanuatu' | 'maltainvest';


can we try this type from @deriv/api-types to be more type safe

Suggested change

export type TShortcode = 'svg' | 'bvi' | 'labuan' | 'vanuatu' | 'maltainvest';

export type TShortcode = DetailsOfEachMT5Loginid['landing_company_short'];

Better get it from the hook. Lets avoid getting it from the api-types

I face a lot of type conflicts after using the type from the API. We'll work on this fix at the next phase of improving our types since those changes are out of scope of this PR

hamza-deriv · 2023-11-14T03:47:30Z

packages/cfd/src/features/hooks/useCurrentList.ts

+    mt5_accounts
+        ?.filter(acc =>
+            show_eu_related_content
+                ? acc.landing_company_short === 'maltainvest'


Make use of config file here. Instead of hardcoded value

This will be done at the stage of removal of dependencies of CFD package. Tried to avoid using shared package as much as possible but seems like we need to use it anyway.

thisyahlen-deriv · 2023-11-14T03:47:37Z

packages/cfd/src/features/hooks/useCurrentList.ts

+*/
+const useCurrentList = () => {
+    const current_list: TCurrentList = {};
+    const { traders_hub } = useStore();


Can we avoid this ?

At this step we're removing the logics from the stores and need to make use of some of the states in the store. What do you guys use for EU users ? We can handle it in the useMT5AccountsList as well.

We have handled this for wallet in useWalletAccountsList. We have is_malta_wallet flag. You can add this same flag in useAccountsList and it will be exposed to useActiveTradingAccount.

show_eu_related_content is based on the content_flag and not is_eu. These 2 are not the same.

Hrmm we dont need to use that. Maybe another PR

hamza-deriv · 2023-11-14T03:48:05Z

packages/cfd/src/features/hooks/useCurrentList.ts

+                : acc.landing_company_short !== 'maltainvest'
+        )
+        .forEach(account => {
+            current_list[getAccountListKey(account, 'mt5', account.landing_company_short)] = {


Platform names from config file

hamza-deriv · 2023-11-14T03:49:54Z

packages/cfd/src/features/hooks/useCurrentList.ts

+const useCurrentList = () => {
+    const current_list: TCurrentList = {};
+    const { traders_hub } = useStore();
+    const { data: mt5_accounts } = useMT5AccountsList();


We can use the CFDAccountsList because here we are using every platform so combined one make more sense.
If we want we can destructure from the cfd_accounts.
Just a suggestion.

Suggested change

const { data: mt5_accounts } = useMT5AccountsList();

const { data: cfd_accounts } = useCFDAccountsList();

Both are possible but it's a matter of preference.

thisyahlen-deriv · 2023-11-14T03:50:27Z

packages/cfd/src/Containers/props.types.ts

@@ -24,7 +24,7 @@ export type TCFDPersonalDetailsContainerProps = {
    onSubmit: (index: number, value: { [key: string]: string }) => void;
 };

-type CFD_Platform = 'dxtrade' | 'mt5' | 'derivez' | 'ctrader';
+export type CFD_Platform = 'dxtrade' | 'mt5' | 'derivez' | 'ctrader';


Maybe you can refer to TPlatforms namepace in types.ts in wallets package as reference. We let the api do the typing

A round of type improvement is done in another PR.

@hirad-deriv better to don't add more technical debt for the future, please update the types here.

Updating the types here requires update of at least 10-15 files.
Should I do it ? In my opinion making all of these changes in this PR is out of scope of it

thisyahlen-deriv · 2023-11-14T04:13:46Z

packages/cfd/src/features/hooks/useCurrentList.ts

+/* 
+    This hook is used to get the existing_accounts_data
+*/
+const useCurrentList = () => {


But i have a question in general. Why we doing this? We can just call the hooks in the components we wanna use and be done with it. Why another transformation ? 🤔

Currently we are facing issue with the Context that which account we need from the response. Moreover in legacy code we ae using it like mt5.synthetic_all@ps+01 as the key for the account response. Thats why we are transforming to the legacy code because we cannot use Context as we want to separate CFD from Appstore. The context can be provided in Appstore but how we use it inside the CFD. If we pass it again we are introducing a new dependency.

If you have any solution please bring it on we will be happy to have that as our main goal is to have a better code in the deriv-app

In addition to what Hamza mentioned, we need to stick with the current logic that we have, add related hooks to do the removal of stores first and then decide if refactoring those logics are necessary. This is the main reason of adding some hooks to the CFD package.

hamza-deriv

LGTM

sonarcloud · 2023-11-17T04:44:08Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

github-actions · 2023-11-17T05:06:15Z

🚀 Smoke test run (2) passed successfully!

github-actions · 2023-11-17T05:06:24Z

🚀 Smoke test run (1) passed successfully!

* [WALL] [Fix] Rostislav / WALL-2594 / Dropdown hitbox size (binary-com#11423) * fix: cursor and clicking * refactor: remove `-moz` * shontzu/CFDS-723/standardize-product-offerings-for-MT5-Financial-accounts (binary-com#10345) * fix: text changes in jurisdiction modal * chore: updated test cases * chore: revert back to xxs (12px) following figma * style: update red shade for 170+ badge * chore: content update * chore: content update * chore: update test case * chore: content update >_> * chore: update test * chore: empty commit * [WALL] Added verification flow for Onfido (binary-com#11412) * feat: added idv submission screen * feat: added idv submission screen * feat: added idv submission screen * fix: applied comments and fix failed test * fix: applied comments * fix: applied comments * feat: added base template for verification flow * chore: fix eslint issues * chore: resolved comments * fix: applied comments * chore: disable warning for dependency --------- Co-authored-by: lubega-deriv <lubega@deriv.com> * [WALL] Hamza/WALL-2608/Modifying useMutation in api package (binary-com#11432) * chore: update the callback function for mutateAsync * chore: remove unused ts-errors comments * [WALL][WALL-2468] use jurisdiction status hook (binary-com#11309) * chore: backup * chore: backup * feat: added use jurisdiction status hook * chore: reverted test changes * chore: added docs * chore: added docs * Merge branch 'use-jurisdiction-hook' of github.com:adrienne-deriv/deriv-app into use-jurisdiction-hook * chore: removed checks for poa, added tests * chore: added ignore checks for use jurisdiction status test file * chore: resolved comments * chore: refactor usepoi with changed prop * [wallets] Aizad/WalletPasswordField v2 (binary-com#11306) * chore: making changes on existing WalletPasswordField - remove usestate within component and added Password prop - change stylings to follow Figma/production * fix: rename MessageContainer component to HelperMessage for better clarity * fix: small changes * chore: added invalid and valid states of the text field and helper message - updated styles in WalletTextfield - updated styles in WalletPasswordField - added constants for helper message' * chore: resolve conflicts - apply comments - replace HTMLIInputProps with ComponentProps * fix: resolve conflicts pt.2 * chore: added new stuff - replace zxcvbn in favor of regex - seperated functions and place inside its own file - remove zxcvbn from wallets package * chore: resolve conflicts pt.1 - move patterns to utils - rename helperMessage to message - remove duplicated types * chore: resolve comments pt.2 - change password validation handler - implement PasswordField inside of CreatePassword - change PasswordViewer handler * chore: resolve comments pt.3 - remove ...rest from the component props and only includes the ones that are being used * fix: resolve comments pt.4 * fix: resolve comments pt.5 * fix: typescript error * fix: command received with no ack error (binary-com#9029) * fix: juri badge (binary-com#11421) * Ako/fix indentation (binary-com#11442) * ci: pass proper shell to the action * ci: fix shell indentation * ci: add bash and format the action (binary-com#11445) * translations: 📚 sync translations with crowdin (binary-com#11447) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * [P2PS] Ameerul /P2PS-675 Share my ads modal (binary-com#9485) * chore: create share my ads modal * chore: fixed animation for closing popup * chore: added test cases, fixed clipboard issue, refactored icons to socials * chore: separated card component out, removed test case * chore: try navigator share * chore: removed popup component * chore: added desktop styles to mixin * chore: update webpackChunkName for share my ads modal * chore: added suggestions * chore: refactored share-my-ads-socials * chore: added partial, removed unused import * chore: changed style name and removed default option for qr code * chore: changed colour to constant * chore: changed the component name * chore: added functions for sharing image * chore: converted file to blob instead * chore: added if check if they can share the file * chore: check if canshare file * chore: added custom message * chore: added emoji * chore: added routing to advert modal * chore: check if qr code has loaded * chore: fixed imports * chore: use toBlob from html-to-image library * chore: use qrcode.react library * chore: fixed sharing qr code * chore: fixed qr code styling * chore: fixed logo size * chore: added loader for when sharing image * chore: fixed setting the loading if is mobile * chore: added navigation to advert and checked for edge cases when navigating * chore: updated stores * chore: fixed getting advertiser list error issue, update styles and custom_message * chore: changed meta tags for link preview * chore: fixed custom ad message * chore: added const for localize message values * chore: fixed failing test cases * chore: changed width of modal * chore: updated relative path * chore: fixed switching to demo error and added base64 image * chore: fixed rounded blurry logo for whatsapp preview * chore: fixed base64 image * chore: changed image * chore: converted svg to jpg base64 * chore: fixed base64 image loading issues * chore: replaced with url * chore: removed unused file, and todo * chore: fixed missing { * chore: refactored getAdvertInfo and removed return value from hook, used currency from store * chore: added custom hook for p2p advert info, refactored component to use hook, added suggestions * chore: set counterparty_advert_id to empty string instead of null * chore: fixed failing test cases * chore: added test case for useP2PAdvertInfo * chore: updated test case * chore: removed eslint, removed props for error dialog, refactored custom_message * chore: added package-lock.json and updated error-dialog * chore: destructured values from general_store * chore: added suggestion, removed react-qrcode-logo * chore: made sure each new icon was optimized with svgo * chore: used is_virtual from client instead of is_demo, placed wrapper outside of block in test case * chore: updated dependency array, hook returns is_buy, is_sell, implemented in advertiser-page * chore: fixed issues with displaying shared advert after logging in * chore: empty commit * chore: updated package-lock.json * chore: updated QRCode to QRCodeSVG * chore: upgraded qrcode.react 1.0.0 to 3.1.0 in wallets * fix: replaced p2p-my-ads__table with my-ads-table style name * chore: removed package-lock for p2p and added suggestions * chore: replaced custom_message with advert_url * fix: url not appending advert_id * [Wallets] Rostislav / WALL-2473 / Pending transactions on mobile (binary-com#11289) * feat: mobile layout * refactor: extract logic from jsx to memo value * feat: adding `onInteraction` * feat: add transaction description * feat: more `WalletActionModal` * style: a little fix * style: use binary-com#11215 * Merge remote-tracking branch 'upstream/master' into rostislav/wall-2473/pending-transaction-list-mobile * refactor: `Tooltip` * style: sort everything out * refactor: sonarcloud role=button * fix: sonarcloud * refactor: remove unnecessary fallback * Merge remote-tracking branch 'upstream/master' into rostislav/wall-2473/pending-transaction-list-mobile * fix: account for binary-com#11304 * refactor: apply suggestions * refactor: some css reverted * refactor: better css * refactor: `ToggleSwitch` * refactor: `onMobileStatusClick` * refactor: remove unnecessary ternary operator * refactor: apply suggestions * [Wallet] george / WALL-2574 / Implement sorting of transferable accounts (binary-com#11419) * feat: ✨ add sorting of transfer accounts, extract hooks * style: 💄 refactor css * refactor: ♻️ rename useModifiedTransferAccounts hook, improve types for landing company * translations: 📚 sync translations with crowdin (binary-com#11457) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * WALL-2589/chore: poa address section (binary-com#11434) * chore: poa address * fix: remove test launch * chore: update v2 * chore: comments and update styles for responsive * fix: remove test launch v2 * fix: comments * [WALL] aizad/chore: created ChangePassword Modal screen: (binary-com#11453) * chore: created ChangePassword Modal screen: - added styles and component * chore: Add tab functionality to CreatePassword modal - added tabs and switching functionality - seperate first page into it's own component * fix: resolve conflicts pt.1 * fix: resolve conflicts pt.2 * [DTRA] / Kate / WEBREL-43 / Test coverage: positions-drawer.tsx in Trader package (binary-com#11353) * refactor: add test for positions drawer * chore: correct grammar * refactor: remove code smell * [WALL] Farhan/WALL-2599/Identity Card Document Submission (binary-com#11446) * feat: create identity card upload screen * refactor: 🔧 refactor divider component * refactor: 🔧 remove styles props in dropzone component * [COJ] Likhith/186/enhance idv form for uganda (binary-com#11295) * chore: new pr for wall 400 * feat: ✨ incorporated change to display the id document name * chore: country selector warning if failed * fix: ♻️ resolved comments * refactor: css file rename * feat: resolved code smell * refactor: expired and failed different warnings * refactor: failed messaged moved to country selector * chore: 💚 trigger build * refactor: review comments * refactor: review comments css * fix: 🐛 incorporated message to display document type * fix: resolved code smell * fix: 🐛 incorporated generic error message * fix: 🐛 added missing dependency * chore: 🔀 synced with master * fix: ♻️ incorporated review comments * fix: resolved un necessary render issue * fix: 🐛 resolved issue with expired status * style: fix side container width in poi (#39) * style: container height fix for POI error messages when content in not overflowing (#40) * fix: onfido message alignment * fix: 🐛 incorporated continue trade button * fix: onfido page mobile * style: no padding on fields container in idv screen (#41) * refactor: onfido hint center alignment fix * fix: odd translate value fix * fix: 🐛 minor CSS fix * fix: green message responsive position * fix: green message full width * fix: ✅ updated testcases * fix: failing tests * refactor: code and ts fixes * fix: display of IDV error * chore: add duplication account error * refactor: added undefined check to response data * chore: review comments * chore: review comments * fix: ♻️ incorporated review comments * fix: barriers test fix form master * fix: barriers test * chore: refactored object.freeze to as const * chore: optional chaining to document type * chore: update spec file for idv-form * test: update personal-details spec * chore: review comments * refactor: css structure * fix: barriers test * fix: ♻️ incorporated review comments * refactor: rename properties * refactor: remove is_appstore from tests * refactor: styles refactor * fix: ⚡ reduced duplicate data * fix: incorporated review comments * fix: ♻️ incorporated review comments * chore: Trigger Build * fix: 🚚 modified path * chore: remove unused fila and variable, updated icons * revert: 🍻 removed icon changes * refactor: removed formatting * fix: removed assignment of default values * fix: 🐛 unable to select a new doc supporting country * fix: 🐛 resolved re-render issue * fix: ⚡ resolved message issue * refactor: 🚚 renamed varibales * fix: 🧪 failing testcase * fix: 🐛 resolved issues with failure messages * fix: 🐛 resolved issue with DIEL accounts * fix: 🐛 fixed issue for DIEL clients * fix: styling issues * fix: ts error for format-response * fix: 🚚 fixed path * fix: 🚚 fixed path * fix: 🐛 resolved styling bugs * fix: 🐛 resolved styling bugs * fix: 🔥 incorporated new styles to fix icon size * fix: 🔥 incorporated new styles to fix icon size * fix: ✅ fixed failing testcase * fix: 💚 eslint issues * fix: layout styles * fix: style issues * fix: styles * fix: moved common styles to core * fix: 💄 updated styles * refactor: incorporated review comments * Merge branch 'master' into combined/wall-400/IDV-error-message-handled * fix: bug: /WEBREL-1358/personal-details page and poa page css issue * fix: layout button * fix: layout button * fix: mt5 next button not getting enabled * fix: resolved issue with button * fix: resolved issue with button * fix: resolved missing dropdown * fix: removed console * fix: incorporated review comments * feat: ✨ incorporated new images and merged checkbox feature * feat: ✨ incorporated new images and merged checkbox feature * fix: idv failed document type * fix: incorporated error message scenario * fix: styling as per new figma * fix: styling as per new figma * fix: spacing between fields * fix: spacing between fields * fix: spacing between fields * fix: incorporated new error code and styles as per new figma * fix: incorporated new error code and styles as per new figma * Merge branch 'master' into likhith/kyc-195/display-idv-error-messages * fix: code smells * chore: trigger rebuild * fix: issue with checkbox * feat: added hint text and updated label text for Uganda * chore: trigger build * fix: 💫 added translation for Additional document * fix: sub task COJ-209 * fix: sub task COJ-209 --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: Shahzaib <shahzaib@deriv.com> * ci: pass the secrets to envs (binary-com#11473) * ci: use 8 cores runner (binary-com#11478) * [WALL] adrienne/chore: removed idv_revoked dependency usepoi (binary-com#11474) * [WALL] adrienne/feat: Integrate idv to flow (binary-com#11451) * feat: added idv submission screen * feat: added idv submission screen * feat: added idv submission screen * fix: applied comments and fix failed test * fix: applied comments * fix: applied comments * feat: added base template for verification flow * chore: fix eslint issues * chore: resolved comments * fix: applied comments * chore: backup * chore: backup * feat: added form validation to flowprovider * chore: removed test changes * chore: comment typo * chore: resolved eslint issues * chore: fix issues with package lock * chore: removed unused imports --------- Co-authored-by: lubega-deriv <lubega@deriv.com> Co-authored-by: yashim-deriv <yashim@regentmarkets.com> * [WALL] thisyahlen/chore: fix deriv x account text and styles (binary-com#11465) * fix: Adjust padding-top of transaction-status component (binary-com#11458) * Hirad/cfds-1213/cfd listing type incompatibility (binary-com#11314) * fix: fixing the cfd_listing type errors * fix: removed the line height * fix: removed the redundant type * chore: changed the type of availability based on suggestions * [CFDS][Refactoring] Hamza/cfds 1391/remove logics from cfd-password-modal.tsx (binary-com#11429) * chore: initial placeholder files added * chore: remove cfd account creation logic * chore: added create-password-form file * chore: remove the bug and code smells * Ako/ fix the runner name (binary-com#11495) * [WALL] Farhan/WALL-2593/Complete your personal details page screen (binary-com#11407) * feat: create personal details form * refactor: 🔧 remove styles props * fix: 🛠️ dropdown scss * fix: ⚒️ missing props * fix: ⚒️ incorrect props * refactor: 🔧 remove default max-width * fix: ⚒️ typscript errors * [WALL]adrienne/chore: fixed an issue where next button is disabled on selecting svg (binary-com#11491) * [WALL]Aizad/WALL-2628/add remaining screens to ChangePassword for MT5 (binary-com#11489) * chore: add remaining screens to ChangePassword for MT5 - added common component for modal content - remove existing component based on the changes - refactor some parts of the ChangePassword modal - added change-password-email inside images file * fix: remove curly brackets * [WALL] thisyahlen/refactor: change and and enter password modal (binary-com#11493) * translations: 📚 sync translations with crowdin (binary-com#11501) Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> * [WALL] sergei/feat: change closeProps to skipProps (binary-com#11497) * [WALL] WALL-2622/thisyahlen/chore: close the modals on escape key by default (binary-com#11464) * chore: close the modals on escape key by default * chore: update comments * chore: remove prop * [WALL] WALL-2626/ thisyahlen/chore: email sent content screen (binary-com#11483) * chore: email sent content screen * chore: fix walletactionscreen imports * chore: conflicts * [WALL] yashim/chore: update codeowners (binary-com#11503) * [Wallets] [Fix] Rostislav / WALL-2591 / Transactions tab wrong order and dropdown width on mobile (binary-com#11459) * fix: inconsistencies * refactor: apply suggestion * refactor: remove `WalletDropdown` `max-width` * [DTRA] / Kate / DTRA-476 / [Code refactoring]: SonarCloud accessibility issues (binary-com#11218) * refactor: improve accessibility for trade description section * refactor: replace div with button in mobile widget file * refactor: replace clickable div with buttons * refactor: add keydown listeners * refactor: create a css class instead of tag selector * refactor: rename constant * fix: revert some changes with button tags * refactor: create function handler * [WALL-2643]: Wallets/Refactor ChangePassword Modal (binary-com#11510) * chore: Refactor ChangePassword Modal - replace ContentTemplate with existing WalletsActionScreen from component - remove css accordingly - remove ContentTemplate file * chore: refactor even more: - replace 3rd screen with SentEmailContent - correct some of the spelling mistakes on WalletsActionScreen - add css based on the changes for ChangePassword Modal * chore: added index inside of ChangePasswordScreens * Ako/ fix docker image creation (binary-com#11516) * ci: remove the verify step * ci: pass proper input names * [WALL] Lubega / WALL-2615 /feat: extend WalletDropdown with WalletTextfield (binary-com#11469) * fix: extend wallet dropdown with textfield * fix: applied comments * fix: applied comments * fix: resolved hitbox issue inside textfield * fix: resolved error * fix: added use callback * fix: added use callback * fix: resolved comments * [WALL] Farhan/WALL-2601/feat: Driving License Document Submission (binary-com#11475) * feat: create identity card upload screen * refactor: 🔧 refactor divider component * refactor: 🔧 remove styles props in dropzone component * feat: 🖊️ create driving license component upload component * fix: ⚒️ typescript errors * [WALL] adrienne/chore: Moved Tabs out of base folder and renamed to WalletsPrimaryTabs (binary-com#11472) * refactor: moved tabs out of base * chore: revert package lock * chore: resolved pr messages * chore: added email svgs * chore: fix sonarcloud * chore: removed unrelated changes * [CFDs] Hirad/ Adding the current_list hook (binary-com#11358) * chore: adding the current_list hook * fix: making changes based on the comments * fix: changed back to the previous state because of the type conflicts * fix: used api types instead of constant types * Shayan/P2PS-1753/refactor exchange rates hook (binary-com#11034) * feat: adding new hook for exchange_rates [WIP] * chore: removed unnecessary parts from the hook * feat: refactoring asset-summary [wip] * feat: adding global provider for handling subscription * build: added ts-usehooks to hooks package * chore: removed unused code * revert: reverted changes in ExchangeRatesProvider * fix: updated the context to store rates in localstorage * refactor: refactored tradershub with the new hook * fix: fixed typescript error * chore: cleaned the code * refactor: refactored cashier transfer page * refactor: replace old exchange rate with the new one * refactor: added exchange rate provider * fix: removed extra imports * refactor: added usep2pexchangerate hook for avoiding duplications * test: added tests for usep2pexchangerate hook * fix: fixed crypto-fiat-converter.spec.tsx errors * fix: fixed test errors * refactor: refactored percentage-selector component * feat: added test for the new useExchangeRate * feat: added new test * fix: resolved pr comment * fix: resolved pr comment * fix: fixing cashier page crashing in test link * fix: trigger ci build * build: updated package-lock.json * fix: fixed test failing * fix: p2p tests * fix: conditions * fix: floating rate tests * fix: resolved pr comments * fix: fixed test failing * fix: resolved pr comments * fix: minor fixes * revert: revert my latest changes for useTotalAccountBalance * fix: bug fixed * fix: checking p2p issue * chore: removed console.log * fix: fixed crypto withdrawal issue * chore: removed asset-summary legacy code * chore: renamed some variables * chore: removed legacy useExchangeRate and useTotalAccountBalance hooks and their tests * refactor: removed legacy code for exchange_rate call * fix: fixing build error * test: removed my-ads-row-renderer test * chore: renamed the variables * chore: removed unused code * fix: added new line at the end of package.json --------- Co-authored-by: Iman Khaleghparast <imankhaleghparast@Shayan-khaleghparasts-Mac-WTQ21CJ93L.local> Co-authored-by: Iman Khaleghparast <imankhaleghparast@Shayan-khaleghparasts-Mac-WTQ21CJ93L-Standard.local> Co-authored-by: Niloofar <niloofar.sadeghi@regentmarkets.com> * ci: verify nginx image (binary-com#11523) * [WALL]adrienne/feat: Send email on account creation (binary-com#11514) * chore: added email svgs * feat: send verification email for new account creation * chore: changed payload * [WALL] Farhan/WALL-2208/Implement Upload Selfie Screen - Manual (binary-com#11515) * feat: 🧸 create selfie screen * fix: 🤸 css and remove prop * add CA to env vars (binary-com#11528) * [P2P]-feat: disclaimer modal for p2p users (binary-com#11046) * feat: disclaimer modal for p2p users * fix: remove unused change * fix: pr review comments * fix: removed wrapper * fix: changed interval logic to timeout * fix: update test * fix: prefix with p2p for the local storage key * fix: added margin for modal content * fix: remove unwanted change * fix: button misaligned in ios * fix: disclaimer interval set to 1 hour * fix: change time to 1 hour for testing * fix: changed interval duration back to 24 hours --------- Co-authored-by: Rostik Kayko <119863957+rostislav-deriv@users.noreply.github.com> Co-authored-by: shontzu <108507236+shontzu-deriv@users.noreply.github.com> Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> Co-authored-by: lubega-deriv <lubega@deriv.com> Co-authored-by: Muhammad Hamza <120543468+hamza-deriv@users.noreply.github.com> Co-authored-by: Aizad Ridzo <103104395+aizad-deriv@users.noreply.github.com> Co-authored-by: Amir Ali <129206554+amir-deriv@users.noreply.github.com> Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: ameerul-deriv <103412909+ameerul-deriv@users.noreply.github.com> Co-authored-by: George Usynin <103181646+heorhi-deriv@users.noreply.github.com> Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Farhan Ahmad Nurzi <125247833+farhan-nurzi-deriv@users.noreply.github.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: Shahzaib <shahzaib@deriv.com> Co-authored-by: yashim-deriv <yashim@regentmarkets.com> Co-authored-by: Nijil Nirmal <62882794+nijil-deriv@users.noreply.github.com> Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> Co-authored-by: yashim-deriv <yashim@deriv.com> Co-authored-by: lubega-deriv <142860499+lubega-deriv@users.noreply.github.com> Co-authored-by: Shayan Khaleghparast <100833613+shayan-deriv@users.noreply.github.com> Co-authored-by: Iman Khaleghparast <imankhaleghparast@Shayan-khaleghparasts-Mac-WTQ21CJ93L.local> Co-authored-by: Iman Khaleghparast <imankhaleghparast@Shayan-khaleghparasts-Mac-WTQ21CJ93L-Standard.local> Co-authored-by: Niloofar <niloofar.sadeghi@regentmarkets.com> Co-authored-by: nada-deriv <122768621+nada-deriv@users.noreply.github.com>

chore: adding the current_list hook

844e5b3

hirad-deriv requested a review from matin-deriv as a code owner November 13, 2023 06:20

hirad-deriv deployed to Preview November 13, 2023 06:21 — with GitHub Actions Active

thisyahlen-deriv reviewed Nov 14, 2023

View reviewed changes

hamza-deriv reviewed Nov 14, 2023

View reviewed changes

thisyahlen-deriv reviewed Nov 14, 2023

View reviewed changes

hamza-deriv reviewed Nov 14, 2023

View reviewed changes

thisyahlen-deriv reviewed Nov 14, 2023

View reviewed changes

fix: making changes based on the comments

4b489b0

hirad-deriv had a problem deploying to Preview November 14, 2023 06:28 — with GitHub Actions Failure

hirad-deriv had a problem deploying to Preview November 14, 2023 06:29 — with GitHub Actions Failure

fix: changed back to the previous state because of the type conflicts

040e28c

hirad-deriv temporarily deployed to Preview November 14, 2023 07:05 — with GitHub Actions Inactive

hirad-deriv deployed to Preview November 14, 2023 07:05 — with GitHub Actions View deployment

thisyahlen-deriv previously approved these changes Nov 15, 2023

View reviewed changes

hamza-deriv approved these changes Nov 15, 2023

View reviewed changes

chore: getting the latest changes of master

d456b1e

hirad-deriv temporarily deployed to Preview November 15, 2023 04:27 — with GitHub Actions Inactive

hirad-deriv deployed to Preview November 15, 2023 04:27 — with GitHub Actions View deployment

fix: used api types instead of constant types

1128c09

hirad-deriv dismissed thisyahlen-deriv’s stale review via 1128c09 November 17, 2023 04:32

hirad-deriv requested a review from ali-hosseini-deriv as a code owner November 17, 2023 04:32

hirad-deriv requested a review from maryia-deriv as a code owner November 17, 2023 04:32

chore: pulled the latest changes of master

12e7f6b

hirad-deriv temporarily deployed to Preview November 17, 2023 04:43 — with GitHub Actions Inactive

hirad-deriv deployed to Preview November 17, 2023 04:43 — with GitHub Actions View deployment

thisyahlen-deriv approved these changes Nov 17, 2023

View reviewed changes

matin-deriv approved these changes Nov 17, 2023

View reviewed changes

hirad-deriv merged commit 479ce80 into binary-com:master Nov 17, 2023
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CFDs] Hirad/ Adding the current_list hook #11358

[CFDs] Hirad/ Adding the current_list hook #11358

hirad-deriv commented Nov 13, 2023

vercel bot commented Nov 13, 2023 •

edited

Loading

github-actions bot commented Nov 13, 2023 •

edited

Loading

github-actions bot commented Nov 13, 2023 •

edited

Loading

coveralls commented Nov 13, 2023 •

edited

Loading

thisyahlen-deriv Nov 14, 2023

hirad-deriv Nov 14, 2023 •

edited

Loading

thisyahlen-deriv Nov 15, 2023

hamza-deriv Nov 14, 2023

thisyahlen-deriv Nov 14, 2023

hirad-deriv Nov 14, 2023 •

edited

Loading

hamza-deriv Nov 14, 2023

hirad-deriv Nov 14, 2023

thisyahlen-deriv Nov 14, 2023

hirad-deriv Nov 14, 2023

thisyahlen-deriv Nov 14, 2023

hirad-deriv Nov 14, 2023

thisyahlen-deriv Nov 15, 2023

hamza-deriv Nov 14, 2023

hamza-deriv Nov 14, 2023

hirad-deriv Nov 14, 2023

thisyahlen-deriv Nov 14, 2023

hirad-deriv Nov 14, 2023

mahdiyeh-deriv Nov 15, 2023

hirad-deriv Nov 15, 2023

thisyahlen-deriv Nov 14, 2023

hamza-deriv Nov 14, 2023

hirad-deriv Nov 14, 2023

hamza-deriv left a comment

sonarcloud bot commented Nov 17, 2023

github-actions bot commented Nov 17, 2023

github-actions bot commented Nov 17, 2023

		@@ -7,6 +7,8 @@ export type TCFDPlatform = 'dxtrade' \| 'mt5' \| 'ctrader' \| 'derivez';

		export type TCFDsPlatformType = 'dxtrade' \| 'derivez' \| 'mt5' \| 'ctrader' \| '';

		export type TShortcode = 'svg' \| 'bvi' \| 'labuan' \| 'vanuatu' \| 'maltainvest';

	export type TShortcode = 'svg' \| 'bvi' \| 'labuan' \| 'vanuatu' \| 'maltainvest';
	export type TShortcode = DetailsOfEachMT5Loginid['landing_company_short'];

	const { data: mt5_accounts } = useMT5AccountsList();
	const { data: cfd_accounts } = useCFDAccountsList();

[CFDs] Hirad/ Adding the current_list hook #11358

[CFDs] Hirad/ Adding the current_list hook #11358

Conversation

hirad-deriv commented Nov 13, 2023

Changes:

Screenshots:

vercel bot commented Nov 13, 2023 • edited Loading

github-actions bot commented Nov 13, 2023 • edited Loading

github-actions bot commented Nov 13, 2023 • edited Loading

coveralls commented Nov 13, 2023 • edited Loading

Choose a reason for hiding this comment

hirad-deriv Nov 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hirad-deriv Nov 14, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hamza-deriv left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Nov 17, 2023

github-actions bot commented Nov 17, 2023

github-actions bot commented Nov 17, 2023

vercel bot commented Nov 13, 2023 •

edited

Loading

github-actions bot commented Nov 13, 2023 •

edited

Loading

github-actions bot commented Nov 13, 2023 •

edited

Loading

coveralls commented Nov 13, 2023 •

edited

Loading

hirad-deriv Nov 14, 2023 •

edited

Loading

hirad-deriv Nov 14, 2023 •

edited

Loading