Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CFDS] [Refactoring] Hamza / Remove the hard-coded variables and replace them with config file #11575

Conversation

hamza-deriv
Copy link
Contributor

@hamza-deriv hamza-deriv commented Nov 20, 2023

Changes:

Please provide a summary of the change.

Description:

  1. Replace all instances of hard-coded variables in the features folder with config file.
  2. Refactor/Split the large components into atomic one
  3. Add the atomic components into their respective folders
  • trading-password-manager.tsx
  • cfd-password-manager-modal.tsx
  • cfd-reset-password-modal.tsx
  • cfd-password-manager-modal.tsx

Expected behaviour:

  • Atomic Components
  • No hard-coded value

Clickup Card:

[Refactoring] Remove the hard-coded variables and replace them with config file

Screenshots:

Please provide some screenshots of the change.

Before

image

After

image

Copy link

vercel bot commented Nov 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 21, 2023 4:31am

@coveralls
Copy link

coveralls commented Nov 20, 2023

Coverage Status

coverage: 27.746% (+0.09%) from 27.655%
when pulling 579cd49 on hamza-deriv:hamza/CFDS-1443/refactor-hard-coded-logic-and-components
into 68c43ea on binary-com:master.

Copy link
Contributor

github-actions bot commented Nov 20, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11575](https://github.com/binary-com/deriv-app/pull/11575)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hamza-deriv-hamza-cfds-1443refactor-h-d4fc90.binary.sx?qa_server=red.derivws.com&app_id=32877
    - **Original**: https://deriv-app-git-fork-hamza-deriv-hamza-cfds-1443refactor-h-d4fc90.binary.sx
- **App ID**: `32877`

Copy link
Contributor

github-actions bot commented Nov 20, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-hamza-deriv-hamza-cfds-1443refactor-h-d4fc90.binary.sx/

Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
43.9% 43.9% Duplication

Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

🚀 Smoke test run (2) passed successfully!

Copy link
Contributor

🚀 Smoke test run (1) passed successfully!

@hirad-deriv hirad-deriv merged commit befa74c into binary-com:master Nov 23, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants