-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CFDS] [Refactoring] Hamza / Remove the hard-coded variables and replace them with config file #11575
[CFDS] [Refactoring] Hamza / Remove the hard-coded variables and replace them with config file #11575
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-hamza-deriv-hamza-cfds-1443refactor-h-d4fc90.binary.sx/ |
packages/cfd/src/features/Containers/trading-password-manager/trading-password-manager.tsx
Outdated
Show resolved
Hide resolved
packages/cfd/src/features/Containers/trading-password-manager/password-reset.tsx
Outdated
Show resolved
Hide resolved
packages/cfd/src/features/Containers/trading-password-manager/change-password.tsx
Outdated
Show resolved
Hide resolved
packages/cfd/src/features/Containers/trading-password-manager/change-password.tsx
Outdated
Show resolved
Hide resolved
packages/cfd/src/features/Containers/cfd-password-modal/cfd-password-modal.tsx
Outdated
Show resolved
Hide resolved
packages/cfd/src/features/Containers/cfd-password-manager-modal/cfd-password-reset.tsx
Show resolved
Hide resolved
packages/cfd/src/features/Containers/cfd-password-manager-modal/cfd-password-reset.tsx
Outdated
Show resolved
Hide resolved
.../cfd/src/features/Containers/cfd-password-manager-modal/cfd-password-manager-tab-content.tsx
Show resolved
Hide resolved
packages/cfd/src/features/Containers/cfd-password-manager-modal/cfd-password-manager-modal.tsx
Outdated
Show resolved
Hide resolved
packages/cfd/src/features/Containers/cfd-password-manager-modal/cfd-password-manager-modal.tsx
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
❌ Smoke test run (2) failed. See logs for details: Visit Action |
🚀 Smoke test run (2) passed successfully! |
🚀 Smoke test run (1) passed successfully! |
Changes:
Please provide a summary of the change.
Description:
Expected behaviour:
Clickup Card:
[Refactoring] Remove the hard-coded variables and replace them with config file
Screenshots:
Please provide some screenshots of the change.
Before
After