Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WALL-2708/chore: fix remaining validations for idv page #11651

Conversation

thisyahlen-deriv
Copy link
Contributor

@thisyahlen-deriv thisyahlen-deriv commented Nov 22, 2023

Changes:

  1. Update the regex for idv flow
  2. Update form values for formik

Screenshots:

Screen.Recording.2023-11-22.at.11.58.12.AM.mov

Copy link

vercel bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 22, 2023 4:14am

Copy link
Contributor

github-actions bot commented Nov 22, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11651](https://github.com/binary-com/deriv-app/pull/11651)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-wall-2708-50eab4.binary.sx?qa_server=red.derivws.com&app_id=31496
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-wall-2708-50eab4.binary.sx
- **App ID**: `31496`

Copy link
Contributor

github-actions bot commented Nov 22, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-wall-2708-50eab4.binary.sx/

Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@matin-deriv matin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matin-deriv matin-deriv merged commit 9e82f3c into binary-com:master Nov 22, 2023
7 of 8 checks passed
@coveralls
Copy link

coveralls commented Nov 22, 2023

Coverage Status

coverage: 28.107%. remained the same
when pulling 20ff017 on thisyahlen-deriv:thisyahlen/WALL-2708/validations_for_idv_flow
into bc09647 on binary-com:master.

Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants