[WALL] Fix POA screen switching condition and POI status hook #11687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adrienne-deriv
requested review from
thisyahlen-deriv,
farhan-nurzi-deriv,
wojciech-deriv,
aizad-deriv and
heorhi-deriv
as code owners
adrienne-deriv
commented
Nov 23, 2023
| @@ -47,7 +47,7 @@ const usePOI = () => { | |||
| const user_country_code = get_settings_data?.citizen || get_settings_data?.country_code; | |||
| const matching_residence_data = residence_list_data?.find(r => r.value === user_country_code); | |||
| const is_idv_supported = matching_residence_data?.identity?.services?.idv?.is_country_supported; | |||
| const is_onfido_supported = matching_residence_data?.identity?.services?.onfido?.documents_supported; | |||
There was a problem hiding this comment.
documents_supported is an empty object {}, is_onfido_supported will always be truthy
adrienne-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
adrienne-deriv
temporarily deployed
to
Preview
GitHub Actions
Inactive
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-adrienne-deriv-fix-poa-screen-not-switched.binary.sx/ |
|
Kudos, SonarCloud Quality Gate passed!
|
|
🚀 Smoke test run (1) passed successfully! |
|
🚀 Smoke test run (2) passed successfully! |
matin-deriv
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please provide a summary of the change.
usePOIwhere Onfido status check for a country is incorrectThe bug
Screen.Recording.2023-11-23.at.11.58.39.AM.mov
Screenshots:
Please provide some screenshots of the change.