Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P2PS] Ameerul /P2PS-2005 Refactor AdErrorTooltipModal #11868

Conversation

ameerul-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

  • Refactored the AdErrorToolTipModal to typescript along with the test file
  • Also extracted AdRateError component out into its own file

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 13, 2023 6:05am

Copy link
Contributor

github-actions bot commented Nov 29, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/11868](https://github.com/binary-com/deriv-app/pull/11868)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ameerul-deriv-p2ps-2005-refactor-ad-e-06f992.binary.sx?qa_server=red.derivws.com&app_id=23929
    - **Original**: https://deriv-app-git-fork-ameerul-deriv-p2ps-2005-refactor-ad-e-06f992.binary.sx
- **App ID**: `23929`

Copy link
Contributor

github-actions bot commented Nov 29, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 76
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-ameerul-deriv-p2ps-2005-refactor-ad-e-06f992.binary.sx/

@coveralls
Copy link

coveralls commented Nov 29, 2023

Coverage Status

coverage: 31.364% (-0.006%) from 31.37%
when pulling 9ee30eb on ameerul-deriv:P2PS-2005-refactor-ad-error-tooltip-modal
into b01e92e on binary-com:master.

farrah-deriv
farrah-deriv previously approved these changes Nov 29, 2023
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
6.6% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

Generating Lighthouse report...

@farrah-deriv farrah-deriv merged commit 299392d into binary-com:master Dec 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants