Likhith/wall 1714/enhance error message handling for poi #11977

likhith-deriv · 2023-12-04T05:34:34Z

Changes:

Error messages have been replaced with ErrorCodes in API to facilitate formatting the content as required in FE
Onfido Error messages will specific and understandable

…handled

…d/wall-400/IDV-error-message-handled

…com:likhith-deriv/deriv-app; branch 'master' of github.com:binary-com/deriv-app into combined/wall-400/IDV-error-message-handled

…d/wall-400/IDV-error-message-handled

…com:likhith-deriv/deriv-app into combined/wall-400/IDV-error-message-handled

…d/wall-400/IDV-error-message-handled

…ndling-for-poi

…/enhance-error-message-handling-for-poi

vercel · 2023-12-04T05:34:39Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Dec 4, 2023 6:07am

gitguardian · 2023-12-04T05:36:07Z

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
-	Generic High Entropy Secret	`a0af8ed`	nx.json	View secret
-	Generic High Entropy Secret	`e21e6f2`	nx.json	View secret
-	Generic High Entropy Secret	`545c948`	nx.json	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

coveralls · 2023-12-04T05:50:52Z

coverage: 29.602% (-0.007%) from 29.609%
when pulling 376f414 on likhith-deriv:likhith/WALL-1714/enhance-error-message-handling-for-poi
into 48a9118 on binary-com:master.

github-actions · 2023-12-04T05:51:23Z

A production App ID was automatically generated for this PR. (log)

PR: Likhith/wall 1714/enhance error message handling for poi #11977
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-likhith-deriv-likhith-wall-1714enhanc-549bf9.binary.sx?qa_server=red.derivws.com&app_id=31371
- Original: https://deriv-app-git-fork-likhith-deriv-likhith-wall-1714enhanc-549bf9.binary.sx
App ID: 31371

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/11977](https://github.com/binary-com/deriv-app/pull/11977)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-likhith-deriv-likhith-wall-1714enhanc-549bf9.binary.sx?qa_server=red.derivws.com&app_id=31371
    - **Original**: https://deriv-app-git-fork-likhith-deriv-likhith-wall-1714enhanc-549bf9.binary.sx
- **App ID**: `31371`

github-actions · 2023-12-04T05:51:57Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	16
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟧 PWA	80

Lighthouse ran with https://deriv-app-git-fork-likhith-deriv-likhith-wall-1714enhanc-549bf9.binary.sx/

sonarcloud · 2023-12-04T05:54:50Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
6 Code Smells

No Coverage information
8.8% Duplication

github-actions · 2023-12-04T06:07:45Z

❌ Smoke test run (2) failed. See logs for details: Visit Action

github-actions · 2023-12-04T06:07:47Z

❌ Smoke test run (1) failed. See logs for details: Visit Action

* fix: ✅ updated testcases * fix: failing tests * refactor: code and ts fixes * fix: display of IDV error * chore: add duplication account error * refactor: added undefined check to response data * chore: review comments * chore: review comments * fix: ⬆️ upgraded SDK and handled language change * fix: ♻️ incorporated review comments * fix: ♻️ refactored code to remove useRef * fix: barriers test fix form master * fix: barriers test * chore: refactored object.freeze to as const * chore: optional chaining to document type * chore: update spec file for idv-form * test: update personal-details spec * chore: review comments * refactor: ♻️ incorporated hooks to handle business logic * refactor: css structure * fix: barriers test * fix: ⚰️ removed unwanted code * test: 🔥 removed mocked tokens * chore: 📝 Added documentation for UseNotificationEvent hook * fix: 💄 incorporated styling * fix: ♻️ incorporated review comments * refactor: rename properties * refactor: remove is_appstore from tests * fix: ♻️ incorporated review comments * refactor: styles refactor * fix: ⚡ reduced duplicate data * fix: incorporated review comments * fix: ♻️ incorporated review comments * chore: Trigger Build * fix: 🚚 modified path * chore: remove unused fila and variable, updated icons * revert: 🍻 removed icon changes * refactor: removed formatting * fix: removed assignment of default values * fix: 🐛 unable to select a new doc supporting country * fix: 🐛 resolved re-render issue * fix: ⚡ resolved message issue * refactor: 🚚 renamed varibales * fix: 🧪 failing testcase * fix: 🐛 resolved issues with failure messages * fix: 🐛 resolved issue with DIEL accounts * fix: 🐛 fixed issue for DIEL clients * fix: styling issues * fix: ts error for format-response * build: 📌 updated package-lock after updating onfido-sdk-ui * fix: 🚚 fixed path * fix: 🚚 fixed path * fix: 🐛 resolved styling bugs * fix: 🐛 resolved styling bugs * fix: ♻️ removed default values * fix: 🔥 incorporated new styles to fix icon size * fix: 🔥 incorporated new styles to fix icon size * fix: ✅ fixed failing testcase * fix: 💚 eslint issues * fix: ⚡ incorporated platform language change * fix: removed store * fix: layout styles * fix: style issues * fix: styles * fix: moved common styles to core * refactor: incorporated review comments * fix: 💄 updated styles * fix: 🐛 reverted code * fix: 🐛 reverted code * refactor: incorporated review comments * fix: 🐛 Onfido SDK language code conversion * fix: migrated hooks * revert: logic for generating code * chore: adding missing testcases * fix: recatored Onfido constants * fix: onfido screen css issues * fix: removed package-lock to resolve merge error * Merge branch 'master' into likhith/KYC-363/onfido-sdk-updation * chore: added package-lock * Merge branch 'master' into combined/wall-400/IDV-error-message-handled * chore: Trigger Build * fix: bug: /WEBREL-1358/personal-details page and poa page css issue * fix: layout button * fix: layout button * fix: mt5 next button not getting enabled * fix: resolved issue with button * fix: resolved issue with button * fix: resolved missing dropdown * fix: removed console * fix: incorporated review comments * feat: ✨ incorporated new images and merged checkbox feature * feat: ✨ incorporated new images and merged checkbox feature * refactor: split components * fix: idv failed document type * fix: removed duplicate import * fix: incorporated error message scenario * fix: styling as per new figma * fix: styling as per new figma * fix: spacing between fields * fix: spacing between fields * fix: spacing between fields * fix: incorporated new error code and styles as per new figma * fix: incorporated new error code and styles as per new figma * feat: incorporated idv-error codes * Merge branch 'master' into likhith/kyc-195/display-idv-error-messages * fix: reverted changes * Incorporate poi context (#55) * chore: incorporate POIContext to keep track of submission * chore: reset poi context state upon route change * refactor: added reset for all path * fix: changed testcases --------- Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> * fix: incorporated Onfido error messages * chore: removed dead code * fix: incorporated review comments * fix: incorporated review comments * fix: import paths * fix: Onfido error for failed selfie check * fix: incorporated missing status code * fix: button width * fix: Error text for Failure of IDV * fix: changed icon badge * fix: onfido check in POI * fix: failing testcase * fix: user flow for POI * fix: layout for Expired scenario in onfido * fix: styling of erro message * fix: code smells * chore: trigger rebuild * fix: issue with checkbox * fix: removed unused import * fix: added keyboard event * fix: resolved build failure * Merge branch 'master' into likhith/KYC-363/onfido-sdk-updation * fix: Onfido styles * fix: resolved code-smells * fix: resolved code smells * fix: code styling * fix: review comments * Merge remote-tracking branch 'upstream/master' into likhith/WALL-1714/enhance-error-message-handling-for-poi * Merge remote-tracking branch 'upstream/master' into likhith/WALL-1714/enhance-error-message-handling-for-poi * Merge remote-tracking branch 'upstream/master' into likhith/WALL-1714/enhance-error-message-handling-for-poi * chore: trigger rebuild --------- Co-authored-by: “yauheni-kryzhyk-deriv” <“yauheni@deriv.me”> Co-authored-by: Shahzaib <shahzaib@deriv.com>

likhith-deriv and others added 30 commits July 6, 2023 15:12

feat: Merge branch 'master' into combined/wall-400/IDV-error-message-…

cf37564

…handled

chore: 🔀 sync with master

c92eb94

Merge branch 'master' into combined/wall-400/IDV-error-message-handled

0ec5333

fix: ✅ updated testcases

2b4a404

Merge branch 'master' into combined/wall-400/IDV-error-message-handled

72f9878

chore:Merge branch 'master' into combined/wall-400/IDV-error-message-…

d686d79

…handled

Merge branch 'master' into combined/wall-400/IDV-error-message-handled

2d98c8e

chore:Merge branch 'master' into combined/wall-400/IDV-error-message-…

63d8a7a

…handled

Merge branch 'master' into combined/wall-400/IDV-error-message-handled

9e1966e

fix: failing tests

5b5ef29

refactor: code and ts fixes

b4fd073

fix: display of IDV error

ec0b232

Merge branch 'master' of github.com:binary-com/deriv-app into combine…

01aaa05

…d/wall-400/IDV-error-message-handled

Merge branch 'combined/wall-400/IDV-error-message-handled' of github.…

9a84342

…com:likhith-deriv/deriv-app; branch 'master' of github.com:binary-com/deriv-app into combined/wall-400/IDV-error-message-handled

Merge branch 'combined/wall-400/IDV-error-message-handled' of github.…

e5f76bd

…com:likhith-deriv/deriv-app; branch 'master' of github.com:binary-com/deriv-app into combined/wall-400/IDV-error-message-handled

chore: add duplication account error

8b57104

refactor: added undefined check to response data

64245d3

Merge branch 'master' of github.com:binary-com/deriv-app into combine…

4b2cd94

…d/wall-400/IDV-error-message-handled

Merge branch 'master' of github.com:binary-com/deriv-app into combine…

c338bd1

…d/wall-400/IDV-error-message-handled

fix: resolve conflicts, update from master

97f17a0

Merge branch 'master' of github.com:binary-com/deriv-app into combine…

674a357

…d/wall-400/IDV-error-message-handled

chore: review comments

1916fc2

chore: review comments

d307fd2

Merge branch 'combined/wall-400/IDV-error-message-handled' of github.…

c7f7418

…com:likhith-deriv/deriv-app into combined/wall-400/IDV-error-message-handled

fix: ⬆️ upgraded SDK and handled language change

96eb0fc

fix: ♻️ incorporated review comments

f890064

fix: ♻️ refactored code to remove useRef

b271632

fix: barriers test fix form master

26c4c53

Merge branch 'master' of github.com:binary-com/deriv-app into combine…

f07b8b2

…d/wall-400/IDV-error-message-handled

fix: barriers test

0700c3c

likhith-deriv added 9 commits November 9, 2023 18:04

fix: resolved code smells

8dbef75

fix: code styling

1f77a36

Merge branch 'master' into likhith/WALL-1714/enhance-error-message-ha…

545c948

…ndling-for-poi

Merge branch 'master' into likhith/WALL-1714/enhance-error-message-ha…

1636cf0

…ndling-for-poi

fix: review comments

1636d24

Merge remote-tracking branch 'upstream/master' into likhith/WALL-1714…

04f27d6

…/enhance-error-message-handling-for-poi

Merge remote-tracking branch 'upstream/master' into likhith/WALL-1714…

e98bfe5

…/enhance-error-message-handling-for-poi

Merge remote-tracking branch 'upstream/master' into likhith/WALL-1714…

5a826b5

…/enhance-error-message-handling-for-poi

Merge remote-tracking branch 'upstream/master' into likhith/WALL-1714…

c3bb0b5

…/enhance-error-message-handling-for-poi

likhith-deriv requested review from ali-hosseini-deriv, matin-deriv, maryia-deriv and amina-deriv as code owners December 4, 2023 05:34

boring-cyborg bot added Account Shared labels Dec 4, 2023

likhith-deriv temporarily deployed to Preview December 4, 2023 05:35 — with GitHub Actions Inactive

chore: trigger rebuild

376f414

likhith-deriv temporarily deployed to Preview December 4, 2023 05:51 — with GitHub Actions Inactive

likhith-deriv merged commit e148070 into binary-com:master Dec 4, 2023
6 of 7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Likhith/wall 1714/enhance error message handling for poi #11977

Likhith/wall 1714/enhance error message handling for poi #11977

likhith-deriv commented Dec 4, 2023

vercel bot commented Dec 4, 2023 •

edited

Loading

gitguardian bot commented Dec 4, 2023 •

edited

Loading

coveralls commented Dec 4, 2023 •

edited

Loading

github-actions bot commented Dec 4, 2023 •

edited

Loading

github-actions bot commented Dec 4, 2023 •

edited

Loading

sonarcloud bot commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

Likhith/wall 1714/enhance error message handling for poi #11977

Likhith/wall 1714/enhance error message handling for poi #11977

Conversation

likhith-deriv commented Dec 4, 2023

Changes:

vercel bot commented Dec 4, 2023 • edited Loading

gitguardian bot commented Dec 4, 2023 • edited Loading

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

coveralls commented Dec 4, 2023 • edited Loading

github-actions bot commented Dec 4, 2023 • edited Loading

github-actions bot commented Dec 4, 2023 • edited Loading

sonarcloud bot commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

github-actions bot commented Dec 4, 2023

vercel bot commented Dec 4, 2023 •

edited

Loading

gitguardian bot commented Dec 4, 2023 •

edited

Loading

coveralls commented Dec 4, 2023 •

edited

Loading

github-actions bot commented Dec 4, 2023 •

edited

Loading

github-actions bot commented Dec 4, 2023 •

edited

Loading