Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRODQA] Hamza/PRODQA-928/[Trader's Hub] EU banner is missing for MF only account Test Failure #12019

Merged

Conversation

hamza-deriv
Copy link
Contributor

@hamza-deriv hamza-deriv commented Dec 5, 2023

Changes:

Please provide a summary of the change.

Fix the test cases failure due to changes of PRODQA-928

Screenshots:

Please provide some screenshots of the change.

Before

image

After

image

Copy link

vercel bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 5, 2023 9:12am

Copy link

sonarcloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@hamza-deriv hamza-deriv changed the title [CFDS] Hamza/PRODQA-928/[Trader's Hub] EU banner is missing for MF only account (#11781) [PRODQA] Hamza/PRODQA-928/[Trader's Hub] EU banner is missing for MF only account (#11781) Dec 5, 2023
@hamza-deriv hamza-deriv changed the title [PRODQA] Hamza/PRODQA-928/[Trader's Hub] EU banner is missing for MF only account (#11781) [PRODQA] Hamza/PRODQA-928/[Trader's Hub] EU banner is missing for MF only account Test Failure Dec 5, 2023
Copy link
Contributor

github-actions bot commented Dec 5, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12019](https://github.com/binary-com/deriv-app/pull/12019)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hamza-deriv-hamza-test-failing-for-mf-client.binary.sx?qa_server=red.derivws.com&app_id=23848
    - **Original**: https://deriv-app-git-fork-hamza-deriv-hamza-test-failing-for-mf-client.binary.sx
- **App ID**: `23848`

Copy link
Contributor

github-actions bot commented Dec 5, 2023

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Dec 5, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 85
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-hamza-deriv-hamza-test-failing-for-mf-client.binary.sx/

@hamza-deriv hamza-deriv merged commit e775809 into binary-com:master Dec 5, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants