Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOT] shafin/BOT-869/fix google drive showing connected even on abort action #12040

Conversation

shafin-deriv
Copy link
Contributor

Changes:

  • Added condition to check if the callback response has the access code and also it doesn't contain any error. Only then proceed to show the user as connected.

Copy link

vercel bot commented Dec 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 6, 2023 4:11am

Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
8.1% 8.1% Duplication

Copy link
Contributor

github-actions bot commented Dec 6, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12040](https://github.com/binary-com/deriv-app/pull/12040)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shafin-deriv-shafin-bot-869fix-google-244e60.binary.sx?qa_server=red.derivws.com&app_id=31477
    - **Original**: https://deriv-app-git-fork-shafin-deriv-shafin-bot-869fix-google-244e60.binary.sx
- **App ID**: `31477`

Copy link
Contributor

github-actions bot commented Dec 6, 2023

❌ Smoke test run (1) failed. See logs for details: Visit Action

@coveralls
Copy link

Coverage Status

coverage: 29.828% (-0.001%) from 29.829%
when pulling f54bba8 on shafin-deriv:shafin/BOT-869/fix--google-drive-connection-issue
into e379c42 on binary-com:master.

Copy link
Contributor

github-actions bot commented Dec 6, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 85
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-shafin-deriv-shafin-bot-869fix-google-244e60.binary.sx/

@sandeep-deriv sandeep-deriv merged commit e15757f into binary-com:master Dec 14, 2023
7 checks passed
sandeep-deriv added a commit that referenced this pull request Dec 14, 2023
sandeep-deriv added a commit that referenced this pull request Dec 14, 2023
maryia-deriv pushed a commit that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants