[DTRA] / Kate / DTRA-566 / Console error while switching between DTrader and TraderHub #12156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kate-deriv
requested review from
ali-hosseini-deriv,
matin-deriv and
maryia-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-dtra-566consoleerroru-1882f9.binary.sx/ |
balakrishna-deriv
previously approved these changes
Dec 12, 2023
akmal-deriv
approved these changes
Dec 12, 2023
henry-deriv
approved these changes
Dec 12, 2023
maryia-deriv
previously approved these changes
Dec 12, 2023
maryia-deriv
approved these changes
Dec 12, 2023
|
|
||
| it('should clear timeout after component was unmount', () => { | ||
| jest.useFakeTimers(); | ||
| jest.spyOn(global, 'clearTimeout'); |
maryia-deriv
previously approved these changes
Dec 12, 2023
|
|
❌ Smoke test run (2) failed. See logs for details: Visit Action |
|
❌ Smoke test run (2) failed. See logs for details: Visit Action |
|
❌ Smoke test run (1) failed. See logs for details: Visit Action |
|
❌ Smoke test run (1) failed. See logs for details: Visit Action |
|
❌ Smoke test run (2) failed. See logs for details: Visit Action |
balakrishna-deriv
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
clearTimoutand added test case.isMounted()check in async codeUpdate: after merging latest master, I discovered, that someone has already applied same fixed and the only file which was left is tests
Screenshots:
Please provide some screenshots of the change.