Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEQ] Jim/FEQ-990/p2p advert information #12213

Merged
merged 8 commits into from
Dec 14, 2023
Merged

[FEQ] Jim/FEQ-990/p2p advert information #12213

merged 8 commits into from
Dec 14, 2023

Conversation

jim-deriv
Copy link
Contributor

Changes:

  • Moved the useAdvertInfo hook from the hooks package to the api package

@vercel Vercel
Copy link

vercel bot commented Dec 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 13, 2023 8:54am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/12213](https://github.com/binary-com/deriv-app/pull/12213)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-jim-deriv-jim-feq-990p2p-advert-information.binary.sx?qa_server=red.derivws.com&app_id=24161
    - **Original**: https://deriv-app-git-fork-jim-deriv-jim-feq-990p2p-advert-information.binary.sx
- **App ID**: `24161`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 76
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-jim-deriv-jim-feq-990p2p-advert-information.binary.sx/

@coveralls
Copy link

coveralls commented Dec 13, 2023 •
edited
Loading

Coverage Status

coverage: 31.386% (+0.02%) from 31.371%
when pulling fe2c31e on jim-deriv:Jim/feq-990/p2p-advert-information
into 9c7a251 on binary-com:master.

@jim-deriv jim-deriv marked this pull request as ready for review December 13, 2023 05:03
@jim-deriv jim-deriv changed the title [FEQ] Jim/feq 990/p2p advert information [FEQ] Jim/FEQ-990/p2p advert information Dec 13, 2023
niloofar-deriv
niloofar-deriv reviewed Dec 13, 2023
View reviewed changes
packages/api/src/hooks/p2p/useAdvertInfo.ts Outdated Show resolved Hide resolved
packages/api/src/hooks/p2p/useAdvertInfo.ts Show resolved Hide resolved
packages/api/src/hooks/p2p/useAdvertInfo.ts Outdated Show resolved Hide resolved
packages/api/src/hooks/p2p/useAdvertInfo.ts Outdated Show resolved Hide resolved
packages/api/src/hooks/p2p/useAdvertInfo.ts Outdated Show resolved Hide resolved
packages/api/src/hooks/p2p/useAdvertInfo.ts Outdated Show resolved Hide resolved
@jim-deriv @niloofar-deriv
chore: update based on code reviews
fe2c31e 
Co-authored-by: Niloofar Sadeghi <93518187+niloofar-deriv@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

adrienne-deriv
adrienne-deriv approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@adrienne-deriv adrienne-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

⏳ Generating Lighthouse report...

@jim-deriv jim-deriv merged commit cf4d1a2 into binary-com:master Dec 14, 2023
6 checks passed
@jim-deriv jim-deriv deleted the Jim/feq-990/p2p-advert-information branch September 19, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niloofar-deriv niloofar-deriv niloofar-deriv approved these changes

@adrienne-deriv adrienne-deriv adrienne-deriv approved these changes

@ameerul-deriv ameerul-deriv ameerul-deriv approved these changes

@farhan-nurzi-deriv farhan-nurzi-deriv farhan-nurzi-deriv left review comments

@thisyahlen-deriv thisyahlen-deriv Awaiting requested review from thisyahlen-deriv

@wojciech-deriv wojciech-deriv Awaiting requested review from wojciech-deriv wojciech-deriv is a code owner

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv ali-hosseini-deriv is a code owner

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jim-deriv @coveralls @niloofar-deriv @adrienne-deriv @ameerul-deriv @farhan-nurzi-deriv