Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WALL] Farhan/WALL-2911/Unit test for WalletsErrorScreen component #12217

Merged
merged 4 commits into from
Dec 13, 2023
Merged

[WALL] Farhan/WALL-2911/Unit test for WalletsErrorScreen component #12217

merged 4 commits into from
Dec 13, 2023

Conversation

farhan-nurzi-deriv
Copy link
Contributor

Changes:

Create Unit test for WalletsErrorScreen component

Screenshots:

image

@vercel Vercel
Copy link

vercel bot commented Dec 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 13, 2023 8:25am

@coveralls
Copy link

coveralls commented Dec 13, 2023 •
edited
Loading

Coverage Status

coverage: 31.391% (+0.03%) from 31.363%
when pulling b4d185f on farhan-nurzi-deriv:farhan/unit-test-wallets-error-screen
into e8c96fa on binary-com:master.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/12217](https://github.com/binary-com/deriv-app/pull/12217)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-unit-test-w-2c4324.binary.sx?qa_server=red.derivws.com&app_id=32679
    - **Original**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-unit-test-w-2c4324.binary.sx
- **App ID**: `32679`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 76
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-unit-test-w-2c4324.binary.sx/

heorhi-deriv
heorhi-deriv previously approved these changes Dec 13, 2023
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
5.5% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

@github-actions GitHub Actions
Copy link
Contributor

❌ Smoke test run (1) failed. See logs for details: Visit Action

@nijil-deriv nijil-deriv merged commit c17ab6c into binary-com:master Dec 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nijil-deriv nijil-deriv nijil-deriv approved these changes

@heorhi-deriv heorhi-deriv heorhi-deriv approved these changes

@wojciech-deriv wojciech-deriv wojciech-deriv approved these changes

@lubega-deriv lubega-deriv lubega-deriv approved these changes

@adrienne-deriv adrienne-deriv Awaiting requested review from adrienne-deriv adrienne-deriv is a code owner

@thisyahlen-deriv thisyahlen-deriv Awaiting requested review from thisyahlen-deriv thisyahlen-deriv is a code owner

@aizad-deriv aizad-deriv Awaiting requested review from aizad-deriv aizad-deriv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@farhan-nurzi-deriv @coveralls @nijil-deriv @heorhi-deriv @wojciech-deriv @lubega-deriv @Farhan-slurrp