Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COJ] shahzaib / COJ-414 / verify button alignment in POI accounts screen #12259

Conversation

shahzaib-deriv
Copy link
Contributor

Changes:

This PR fixes the alignment issue with the Verify button in POI screen in accounts when the POI is rejected at least once.

Screenshots:

Screenshot 2023-12-14 at 11 58 55 AM

Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 14, 2023 4:23am

Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12259](https://github.com/binary-com/deriv-app/pull/12259)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shahzaib-deriv-coj-414poi-verify-butt-b197ea.binary.sx?qa_server=red.derivws.com&app_id=24220
    - **Original**: https://deriv-app-git-fork-shahzaib-deriv-coj-414poi-verify-butt-b197ea.binary.sx
- **App ID**: `24220`

Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 17
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-shahzaib-deriv-coj-414poi-verify-butt-b197ea.binary.sx/

Copy link
Contributor

@suisin-deriv suisin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amina-deriv amina-deriv merged commit 52b9c32 into binary-com:master Dec 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants