Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Sergei / wall - 3008 / Unit tests for useInputDecimalFormatter hook #12276

Conversation

sergei-deriv
Copy link
Contributor

@sergei-deriv sergei-deriv commented Dec 14, 2023

Changes:

  • Create unit tests for useInputDecimalFormatter hook
  • Fix check for +/- sign in useInputDecimalFormatter hook (need to check 1st char instead of left part of the input number)

Card:

https://app.clickup.com/t/20696747/WALL-3008

Screenshots:

Screenshot 2023-12-14 at 12 35 33

Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 14, 2023 9:56am

Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
4.4% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@wojciech-deriv wojciech-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving this PR, the original hook probably requires very solid refactor / updates

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12276](https://github.com/binary-com/deriv-app/pull/12276)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-sergei-deriv-sergei-wall-3008test-use-d482d5.binary.sx?qa_server=red.derivws.com&app_id=23843
    - **Original**: https://deriv-app-git-fork-sergei-deriv-sergei-wall-3008test-use-d482d5.binary.sx
- **App ID**: `23843`

@coveralls
Copy link

coveralls commented Dec 14, 2023

Coverage Status

coverage: 31.695% (+0.07%) from 31.622%
when pulling 64913a6 on sergei-deriv:sergei/wall-3008/test-useInputDecimalFormatter
into b822ed8 on binary-com:master.

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 76
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-sergei-deriv-sergei-wall-3008test-use-d482d5.binary.sx/

Copy link
Contributor

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

Generating Lighthouse report...

@mahdiyeh-deriv mahdiyeh-deriv merged commit a922a7a into binary-com:master Dec 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants