Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] [Fix] Rostislav / WALL-3096 / Fix amounts not fitting in ATM inputs on mobile #12377

Conversation

rostislav-deriv
Copy link
Contributor

@rostislav-deriv rostislav-deriv commented Dec 19, 2023

Changes:

  • make it so that the max number of digits for a transfer input field is the same as the number of digits in $100,000.00 converted to the currency corresponding to the input field, $100,000.00 being the sort of global cap for transfers as it's the biggest limit we have for those
  • change useInputDecimalFormatter behaviour to always add fractionDigits, given that it's still defaulting to 2 even when not passed
  • add tests for TransferFormAmountInput

Screenshots:

Screen.Recording.2023-12-19.at.18.56.28.mov

Copy link

vercel bot commented Dec 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 4, 2024 11:37am

Copy link
Contributor

github-actions bot commented Dec 19, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12377](https://github.com/binary-com/deriv-app/pull/12377)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-rostislav-deriv-rostislav-wall-3096fi-453575.binary.sx?qa_server=red.derivws.com&app_id=32210
    - **Original**: https://deriv-app-git-fork-rostislav-deriv-rostislav-wall-3096fi-453575.binary.sx
- **App ID**: `32210`

Copy link
Contributor

github-actions bot commented Dec 19, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-rostislav-deriv-rostislav-wall-3096fi-453575.binary.sx/

@coveralls
Copy link

coveralls commented Dec 19, 2023

Coverage Status

coverage: 34.473% (+0.2%) from 34.236%
when pulling 22f579d on rostislav-deriv:rostislav/wall-3096/fix-atm-input-amount-not-fitting
into a8451d5 on binary-com:master.

wojciech-deriv
wojciech-deriv previously approved these changes Dec 20, 2023
@rostislav-deriv rostislav-deriv force-pushed the rostislav/wall-3096/fix-atm-input-amount-not-fitting branch from 6fa54bb to a074c40 Compare December 22, 2023 15:11
Copy link

sonarcloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.6% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@nijil-deriv nijil-deriv merged commit 0373314 into binary-com:master Jan 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants