Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added FATCA declaration section #12490

Conversation

likhith-deriv
Copy link
Contributor

@likhith-deriv likhith-deriv commented Dec 25, 2023

Changes:

Added FATCA declaration section under Terms and Condition for both CR and MF Real account signup page.

The section contains 6 points and a dropdown for users to select Yes to accept and No to reject

Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

Copy link

vercel bot commented Dec 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 5, 2024 7:05am

Copy link
Contributor

github-actions bot commented Dec 25, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12490](https://github.com/binary-com/deriv-app/pull/12490)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-likhith-deriv-likhith-wall-2715add-fa-ed869f.binary.sx?qa_server=red.derivws.com&app_id=38743
    - **Original**: https://deriv-app-git-fork-likhith-deriv-likhith-wall-2715add-fa-ed869f.binary.sx
- **App ID**: `38743`

@coveralls
Copy link

coveralls commented Dec 25, 2023

Coverage Status

coverage: 34.683% (+0.03%) from 34.657%
when pulling 8318c61 on likhith-deriv:likhith/WALL-2715/add-FATCA-declaration-in-TnC
into 276ef09 on binary-com:master.

Copy link
Contributor

github-actions bot commented Dec 25, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 16
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-likhith-deriv-likhith-wall-2715add-fa-ed869f.binary.sx/

Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have nothing to add. Please review your pull request with other seniors and get their feedback.

Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have nothing to add. Please review your pull request with other seniors and get their feedback.

amina-deriv
amina-deriv previously approved these changes Dec 26, 2023
Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
5.1% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

Copy link
Contributor

github-actions bot commented Jan 5, 2024

❌ Smoke test run (2) failed. See logs for details: Visit Action

@likhith-deriv likhith-deriv merged commit 9e78e2d into binary-com:master Feb 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants