Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Lubega / WALL-3211 / Fix: Transfer message missing 'Wallet' in fiat transfer #12699

Conversation

lubega-deriv
Copy link
Contributor

Changes:

  • Fixed missing 'Wallet' for fiat account in transfer message

Screenshots:

image image

Copy link

vercel bot commented Jan 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 3, 2024 8:37am

Copy link

sonarcloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jan 3, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12699](https://github.com/binary-com/deriv-app/pull/12699)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-3211-transfer-messa-997110.binary.sx?qa_server=red.derivws.com&app_id=32511
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-3211-transfer-messa-997110.binary.sx
- **App ID**: `32511`

Copy link
Contributor

github-actions bot commented Jan 3, 2024

❌ Smoke test run (1) failed. See logs for details: Visit Action

@coveralls
Copy link

Coverage Status

coverage: 34.223% (+0.002%) from 34.221%
when pulling 99ae5b8 on lubega-deriv:WALL-3211/transfer-message-missing-fiat-name
into 774cefe on binary-com:master.

Copy link
Contributor

github-actions bot commented Jan 3, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 88
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-wall-3211-transfer-messa-997110.binary.sx/

@nijil-deriv nijil-deriv merged commit ff643fe into binary-com:master Jan 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants