Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOT] chore: add purchase condition value directly under purchase condition… #12922

Conversation

shafin-deriv
Copy link
Contributor

Set contract type as both when loading a quick strategy.

  • Change type to 'both' when adding to XML from QS form
  • Update purchase value to hold type was previously holding

Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jan 12, 2024 4:16am

Copy link

sonarcloud bot commented Jan 12, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
7.2% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/12922](https://github.com/binary-com/deriv-app/pull/12922)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shafin-deriv-shafin-bot-1086chore-inv-3344b1.binary.sx?qa_server=red.derivws.com&app_id=24160
    - **Original**: https://deriv-app-git-fork-shafin-deriv-shafin-bot-1086chore-inv-3344b1.binary.sx
- **App ID**: `24160`

@coveralls
Copy link

Coverage Status

coverage: 34.564% (+0.001%) from 34.563%
when pulling 26eed83 on shafin-deriv:shafin/BOT-1086/chore--investigate-purchase-condition-set-from-qs
into 6636e69 on binary-com:master.

Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 18
🟧 Accessibility 89
🟢 Best practices 92
🟢 SEO 92
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-shafin-deriv-shafin-bot-1086chore-inv-3344b1.binary.sx/

@vinu-deriv vinu-deriv merged commit 2e05635 into binary-com:master Jan 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants